Simplify SpellChecker::markAllMisspellingsAndBadGrammar()

Simplify SpellChecker::markAllMisspellingsAndBadGrammar()

This patch removes parameter |grammarSelection| from the above named function
because it can be obtained from the other parameter |spellingSelection|; then
it makes the function absorbed by its wrapper |markMisspellingsAndBadGrammar()|
to simplify code.

BUG=633509
TESt=n/a; no visible change

Committed: https://crrev.com/b3d3c3a275859f83cbe4cd55c17787e59ace1507
Cr-Commit-Position: refs/heads/master@{#412166}

[Xiaocheng, 2016-08-15 05:39:07]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 05:39:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 07:02:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 07:02:25]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-16 02:07:00]

Description was changed from

==========
Simplify SpellChecker::markAllMisspellingsAndBadGrammar()

BUG=
==========

to

==========
Simplify SpellChecker::markAllMisspellingsAndBadGrammar()

This patch removes parameter |grammarSelection| from the above named function
because it can be obtained from the other parameter |spellingSelection|; then
it makes the function absorbed by its wrapper |markMisspellingsAndBadGrammar()|
to simplify code.

BUG=635509
TESt=n/a; no visible change
==========

[Xiaocheng, 2016-08-16 02:07:00]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-08-16 02:09:53]

PTAL.

I noticed that in this function |grammarSelection| is basically always equal to
|spellingSelection| extended to sentence boundaries. The only exception is in
|markMisspellingsAfterLineBreak()| which extends to paragraph boundaries;
However, using sentence boundary also seems fine here.

So I made this patch to get rid of one parameter from that function.

[yosin_UTC9, 2016-08-16 02:28:47]

lgtm

https://codereview.chromium.org/2243173003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2243173003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:295: if
(!isContinuousSpellCheckingEnabled())
BTW, Could you rename |isContinuousSpellCheckingEnabled()| to
|isSpellCheckingEnabled()|?
|isContinuousSpellCheckingEnabled()| makes us confusing. (~_~)

[Xiaocheng, 2016-08-16 02:50:25]

On 2016/08/16 at 02:28:47, yosin wrote:
> lgtm
> 
>
https://codereview.chromium.org/2243173003/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp
(right):
> 
>
https://codereview.chromium.org/2243173003/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:295: if
(!isContinuousSpellCheckingEnabled())
> BTW, Could you rename |isContinuousSpellCheckingEnabled()| to
|isSpellCheckingEnabled()|?
> |isContinuousSpellCheckingEnabled()| makes us confusing. (~_~)

Yeah, that will be in a future patch.

[Xiaocheng, 2016-08-16 04:30:09]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-08-16 04:30:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 04:33:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-16 04:35:47]

Description was changed from

==========
Simplify SpellChecker::markAllMisspellingsAndBadGrammar()

This patch removes parameter |grammarSelection| from the above named function
because it can be obtained from the other parameter |spellingSelection|; then
it makes the function absorbed by its wrapper |markMisspellingsAndBadGrammar()|
to simplify code.

BUG=635509
TESt=n/a; no visible change
==========

to

==========
Simplify SpellChecker::markAllMisspellingsAndBadGrammar()

This patch removes parameter |grammarSelection| from the above named function
because it can be obtained from the other parameter |spellingSelection|; then
it makes the function absorbed by its wrapper |markMisspellingsAndBadGrammar()|
to simplify code.

BUG=635509
TESt=n/a; no visible change

Committed: https://crrev.com/b3d3c3a275859f83cbe4cd55c17787e59ace1507
Cr-Commit-Position: refs/heads/master@{#412166}
==========

[commit-bot: I haz the power, 2016-08-16 04:35:47]

Patchset 1 (id:??) landed as
https://crrev.com/b3d3c3a275859f83cbe4cd55c17787e59ace1507
Cr-Commit-Position: refs/heads/master@{#412166}

[Xiaocheng, 2016-08-16 05:35:39]

Description was changed from

==========
Simplify SpellChecker::markAllMisspellingsAndBadGrammar()

This patch removes parameter |grammarSelection| from the above named function
because it can be obtained from the other parameter |spellingSelection|; then
it makes the function absorbed by its wrapper |markMisspellingsAndBadGrammar()|
to simplify code.

BUG=635509
TESt=n/a; no visible change

Committed: https://crrev.com/b3d3c3a275859f83cbe4cd55c17787e59ace1507
Cr-Commit-Position: refs/heads/master@{#412166}
==========

to

==========
Simplify SpellChecker::markAllMisspellingsAndBadGrammar()

This patch removes parameter |grammarSelection| from the above named function
because it can be obtained from the other parameter |spellingSelection|; then
it makes the function absorbed by its wrapper |markMisspellingsAndBadGrammar()|
to simplify code.

BUG=633509
TESt=n/a; no visible change

Committed: https://crrev.com/b3d3c3a275859f83cbe4cd55c17787e59ace1507
Cr-Commit-Position: refs/heads/master@{#412166}
==========