SVG: Use counters for SMIL methods on animation elements

SVG: Use counters for SMIL methods on animation elements

We define two new use counters, to cover the methods defined in
SVGAnimationElement.idl

New use counter SVGSMILAnimationElementTiming covers
    float getStartTime();
    float getCurrentTime();
    float getSimpleDuration();

New use counter SVGSMILBeginEndAnimationElement covers
    void beginElement();
    void beginElementAt(float offset);
    void endElement();
    void endElementAt(float offset);

Committed: https://crrev.com/0f426d842b1bbacd4473012e043f77f697068346
Cr-Commit-Position: refs/heads/master@{#412431}

[Eric Willigers, 2016-08-15 01:16:39]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 01:16:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-08-15 01:17:10]

ericwilligers@chromium.org changed reviewers:
+ fs@opera.com

[commit-bot: I haz the power, 2016-08-15 01:18:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 01:18:20]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[kouhei (in TOK), 2016-08-15 01:26:41]

kouhei@chromium.org changed reviewers:
+ kouhei@chromium.org

[kouhei (in TOK), 2016-08-15 01:26:42]

drive-by: What about SVGSVGElement::getCurrentTime

[Eric Willigers, 2016-08-15 03:23:55]

On 2016/08/15 01:26:42, kouhei wrote:
> drive-by: What about SVGSVGElement::getCurrentTime

For SVGSVGElement use counters see
https://codereview.chromium.org/2246023002/

[kouhei (in TOK), 2016-08-15 03:34:45]

On 2016/08/15 03:23:55, Eric Willigers wrote:
> On 2016/08/15 01:26:42, kouhei wrote:
> > drive-by: What about SVGSVGElement::getCurrentTime
> 
> For SVGSVGElement use counters see
> https://codereview.chromium.org/2246023002/

Thanks!

https://codereview.chromium.org/2243173002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp (right):

https://codereview.chromium.org/2243173002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp:242:
UseCounter::count(document(), UseCounter::SVGSMILAnimationElementTiming);
If you intend to only measure JS callers, you can use
[MeasureAs=SVGSMILAnimationElementTiming] IDL attribute to autogen these.

[Eric Willigers, 2016-08-15 04:30:50]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 04:30:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-08-15 04:31:49]

https://codereview.chromium.org/2243173002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp (right):

https://codereview.chromium.org/2243173002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/svg/SVGAnimationElement.cpp:242:
UseCounter::count(document(), UseCounter::SVGSMILAnimationElementTiming);
On 2016/08/15 03:34:45, kouhei wrote:
> If you intend to only measure JS callers, you can use
> [MeasureAs=SVGSMILAnimationElementTiming] IDL attribute to autogen these.

Done.

[kouhei (in TOK), 2016-08-15 04:32:45]

lgtm

[Eric Willigers, 2016-08-15 05:00:19]

ericwilligers@chromium.org changed reviewers:
+ mkwst@chromium.org

[Eric Willigers, 2016-08-15 05:00:19]

+mkwst for histograms

[commit-bot: I haz the power, 2016-08-15 06:55:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 06:55:44]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Eric Willigers, 2016-08-16 00:08:02]

ericwilligers@chromium.org changed reviewers:
+ rch@chromium.org

[Ryan Hamilton, 2016-08-16 14:20:28]

Was I added to this CL by mistake? I'm unfamiliar with the code in question.

[Eric Willigers, 2016-08-16 21:14:38]

ericwilligers@chromium.org changed reviewers:
+ holte@chromium.org
- rch@chromium.org

[Eric Willigers, 2016-08-16 21:14:38]

+holte for histogram OWNERS

-rch, added by mistake.

[Steven Holte, 2016-08-16 22:05:25]

lgtm

[Eric Willigers, 2016-08-16 23:39:58]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-08-16 23:39:58]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org,
holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2243173002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-16 23:40:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 02:37:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-17 02:39:28]

Description was changed from

==========
SVG: Use counters for SMIL methods on animation elements

We define two new use counters, to cover the methods defined in
SVGAnimationElement.idl

New use counter SVGSMILAnimationElementTiming covers
    float getStartTime();
    float getCurrentTime();
    float getSimpleDuration();

New use counter SVGSMILBeginEndAnimationElement covers
    void beginElement();
    void beginElementAt(float offset);
    void endElement();
    void endElementAt(float offset);
==========

to

==========
SVG: Use counters for SMIL methods on animation elements

We define two new use counters, to cover the methods defined in
SVGAnimationElement.idl

New use counter SVGSMILAnimationElementTiming covers
    float getStartTime();
    float getCurrentTime();
    float getSimpleDuration();

New use counter SVGSMILBeginEndAnimationElement covers
    void beginElement();
    void beginElementAt(float offset);
    void endElement();
    void endElementAt(float offset);

Committed: https://crrev.com/0f426d842b1bbacd4473012e043f77f697068346
Cr-Commit-Position: refs/heads/master@{#412431}
==========

[commit-bot: I haz the power, 2016-08-17 02:39:29]

Patchset 3 (id:??) landed as
https://crrev.com/0f426d842b1bbacd4473012e043f77f697068346
Cr-Commit-Position: refs/heads/master@{#412431}