Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: tests/ColorSpaceTest.cpp

Issue 2243143002: Add --serial mode to dm, runs unit tests serially (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Run test serially Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/ColorSpaceTest.cpp
diff --git a/tests/ColorSpaceTest.cpp b/tests/ColorSpaceTest.cpp
index 66860da590d12dd4838ce0a714514b3cb18f8d50..9cfcc068528347c93fa29e2b8c2e9d1ff83bd0c4 100644
--- a/tests/ColorSpaceTest.cpp
+++ b/tests/ColorSpaceTest.cpp
@@ -259,3 +259,15 @@ DEF_TEST(ColorSpace_Equals, r) {
REPORTER_ASSERT(r, !SkColorSpace::Equals(z30.get(), upperRight.get()));
REPORTER_ASSERT(r, !SkColorSpace::Equals(upperRight.get(), adobe.get()));
}
+
+// This test is only interesting on 32-bit builds.
+#if defined(SK_CPU_X86) || defined(SK_CPU_ARM32)
mtklein 2016/08/16 23:54:06 Do we really need to not have the test exist? Can
msarett 2016/08/17 12:40:45 Sure, sgtm
+
+DEF_TEST(ColorSpaceCRBug, r) {
+ sk_sp<SkData> data = SkData::MakeFromFileName(
+ GetResourcePath("invalid_images/crbug636268.png").c_str());
+ SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(data.get()));
+ REPORTER_ASSERT(r, codec.get());
+}
+
+#endif
« infra/bots/recipes/swarm_test.py ('K') | « resources/invalid_images/crbug636268.png ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698