Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: infra/bots/recipes/swarm_test.py

Issue 2243143002: Add --serial mode to dm, runs unit tests serially (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Run test serially Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: infra/bots/recipes/swarm_test.py
diff --git a/infra/bots/recipes/swarm_test.py b/infra/bots/recipes/swarm_test.py
index 5b9d993f2e6733ae10008b862c9eb2ab2f42db37..b2074a3c614b77bbcae5f33cf710251eb0589454 100644
--- a/infra/bots/recipes/swarm_test.py
+++ b/infra/bots/recipes/swarm_test.py
@@ -307,6 +307,7 @@ def dm_flags(bot):
if 'NexusPlayer' in bot:
match.append('~ResourceCache')
+ match.append('~ColorSpaceCRBug')
mtklein 2016/08/16 23:54:06 Is this still going to be necessary once we've mad
msarett 2016/08/17 12:40:45 I'll run the trybot, but I think we'll still need
mtklein 2016/08/17 12:45:12 So you're saying it allocates 2 giant tables, then
msarett 2016/08/17 12:51:47 This is actually what we do - the large memory use
if 'Nexus10' in bot: # skia:5509
match.append('~CopySurface')
@@ -320,6 +321,10 @@ def dm_flags(bot):
if 'TSAN' in bot:
match.extend(['~ReadWriteAlpha']) # Flaky on TSAN-covered on nvidia bots.
+ # For memory intensive tests that we don't want to run multi-threaded.
+ serial = []
+ serial.append('ColorSpaceCRBug')
+
if blacklist:
args.append('--blacklist')
args.extend(blacklist)
@@ -328,6 +333,10 @@ def dm_flags(bot):
args.append('--match')
args.extend(match)
+ if serial:
+ args.append('--serial')
+ args.extend(serial)
+
# These bots run out of memory running RAW codec tests. Do not run them in
# parallel
if ('NexusPlayer' in bot or 'Nexus5' in bot or 'Nexus9' in bot

Powered by Google App Engine
This is Rietveld 408576698