Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2243133002: Pull handling of blurred circles out of GrRRectBlurEffect::Make (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Pull handling of blurred circles out of GrRRectBlurEffect::Make GrRRectBlurEffect is going away so this process can't live there anymore. Split out of: https://codereview.chromium.org/2245653002/ (Start using vertex attributes for nine-patch blurred rrect draws) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2243133002 Committed: https://skia.googlesource.com/skia/+/0dafbde31f4485470471dc9885785e2b9ac4b4ca

Patch Set 1 #

Patch Set 2 : Clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -13 lines) Patch
M src/effects/SkBlurMaskFilter.cpp View 1 4 chunks +32 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
robertphillips
4 years, 4 months ago (2016-08-14 20:49:54 UTC) #5
bsalomon
lgtm
4 years, 4 months ago (2016-08-15 13:51:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243133002/20001
4 years, 4 months ago (2016-08-15 16:03:51 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 16:04:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/0dafbde31f4485470471dc9885785e2b9ac4b4ca

Powered by Google App Engine
This is Rietveld 408576698