Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2243073002: Fix batch test as well. (Closed)

Created:
4 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
4 years, 4 months ago
Reviewers:
Bill Hesse, sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : Fix batch test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M tests/compiler/dart2js/dart2js_batch_test.dart View 2 chunks +7 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/launch_helper.dart View 1 chunk +15 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Siggi Cherem (dart-lang)
tbr (yet another very similar fix)
4 years, 4 months ago (2016-08-12 23:09:20 UTC) #3
sra1
lgtm
4 years, 4 months ago (2016-08-12 23:16:12 UTC) #4
Siggi Cherem (dart-lang)
Committed patchset #1 (id:20001) manually as 88383fb5e17ca552e301c83edf8597188729a8e9 (presubmit successful).
4 years, 4 months ago (2016-08-12 23:19:17 UTC) #6
Bill Hesse
4 years, 4 months ago (2016-08-15 15:50:04 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698