Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2243063002: Hook up the OfflinePageDownloadBridge to UI actions open/delete/download (Closed)

Created:
4 years, 4 months ago by Dmitry Titov
Modified:
4 years, 4 months ago
Reviewers:
gone
CC:
chromium-reviews, asanka, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hook up the OfflinePageDownloadBridge to UI actions open/delete/download BUG=630817 Committed: https://crrev.com/b43f7be9e04d4c8f9d4aa56296e5ca0f9310b6c9 Cr-Commit-Position: refs/heads/master@{#411832}

Patch Set 1 #

Patch Set 2 : remove debug log #

Patch Set 3 : fix build break #

Messages

Total messages: 15 (10 generated)
Dmitry Titov
Open and delete work now! Delete is not reflected right away in UI - I ...
4 years, 4 months ago (2016-08-12 22:58:49 UTC) #4
gone
lgtm
4 years, 4 months ago (2016-08-12 23:04:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2243063002/40001
4 years, 4 months ago (2016-08-12 23:44:46 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-13 00:32:59 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-13 00:36:46 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b43f7be9e04d4c8f9d4aa56296e5ca0f9310b6c9
Cr-Commit-Position: refs/heads/master@{#411832}

Powered by Google App Engine
This is Rietveld 408576698