Issue 224303004: Stop passing the root node to node lists traversal functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 224303004: Stop passing the root node to node lists traversal functions (Closed)

Created:
6 years, 8 months ago by Inactive

Modified:
6 years, 8 months ago

Reviewers:
esprehn, adamk

CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Stop passing the root node to node lists traversal functions Stop passing the root node to node lists traversal functions. Their implementation can call LiveNodeListBase::rootNode() if needed and do not really need it to be passed in argument. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170800

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -49 lines)			Patch
M	Source/core/dom/ChildNodeList.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/ChildNodeList.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/LiveNodeList.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/LiveNodeList.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/LiveNodeListBase.h	View	4 chunks	+9 lines, -7 lines	0 comments	Download
M	Source/core/html/CollectionIndexCache.h	View	5 chunks	+12 lines, -13 lines	0 comments	Download
M	Source/core/html/HTMLCollection.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	5 chunks	+15 lines, -17 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

adamk

lgtm, looks like this avoids some unnecessary argument passing in a good number of cases.

6 years, 8 months ago (2014-04-03 21:09:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/224303004/1

6 years, 8 months ago (2014-04-03 21:20:52 UTC) #4

Message was sent while issue was closed.

Change committed as 170800

Expand Messages | Collapse Messages