Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc

Issue 2242943002: Update device name in chooser when device changes name (desktops) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated device name in chooser when device changes name Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
diff --git a/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc b/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
index afcedf20e2f75523ebcd5b46d85f47dbfb1661e0..5158a3ed74a22fd8c2e6ba27060cf96b2b6cda53 100644
--- a/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
+++ b/chrome/browser/ui/views/extensions/chooser_dialog_view_unittest.cc
@@ -172,6 +172,25 @@ TEST_F(ChooserDialogViewTest, SelectAnOptionAndRemoveTheSelectedOption) {
EXPECT_TRUE(cancel_button_->enabled());
}
+TEST_F(ChooserDialogViewTest, SelectAnOptionAndUpdateTheSelectedOption) {
+ mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));
+ mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("b"));
+ mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("c"));
+ EXPECT_FALSE(ok_button_->enabled());
+ EXPECT_TRUE(cancel_button_->enabled());
+
+ // Select option 1.
+ table_view_->Select(1);
+ EXPECT_TRUE(ok_button_->enabled());
+ EXPECT_TRUE(cancel_button_->enabled());
+
+ // Update option 1.
+ mock_chooser_controller_->OptionUpdated(base::ASCIIToUTF16("b"),
+ base::ASCIIToUTF16("d"));
+ EXPECT_TRUE(ok_button_->enabled());
+ EXPECT_TRUE(cancel_button_->enabled());
msw 2016/08/12 22:19:34 optional nit: remove "d" after this and check that
juncai 2016/08/15 18:11:19 Done.
+}
+
TEST_F(ChooserDialogViewTest,
AddAnOptionAndSelectItAndRemoveTheSelectedOption) {
mock_chooser_controller_->OptionAdded(base::ASCIIToUTF16("a"));

Powered by Google App Engine
This is Rietveld 408576698