chrome/browser/ui/views/chooser_content_view.cc - Issue 2242943002: Update device name in chooser when device changes name (desktops)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/chooser_content_view.cc

Issue 2242943002: Update device name in chooser when device changes name (desktops) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated device name in chooser when device changes name Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm ('K') | « chrome/browser/ui/views/chooser_content_view.h ('k') | chrome/browser/ui/views/chooser_content_view_unittest.cc » ('j') | chrome/browser/ui/views/chooser_content_view_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/chooser_content_view.cc

diff --git a/chrome/browser/ui/views/chooser_content_view.cc b/chrome/browser/ui/views/chooser_content_view.cc

index 6ae3d32f4a50e61d2ff570234140d02958829013..e064ad710bcbd9f4018f666d00bf33a1c85d9e7e 100644

--- a/chrome/browser/ui/views/chooser_content_view.cc

+++ b/chrome/browser/ui/views/chooser_content_view.cc

@@ -98,6 +98,11 @@ void ChooserContentView::OnOptionRemoved(size_t index) {

UpdateTableView();

}

+void ChooserContentView::OnOptionUpdated(size_t index) {

+ table_view_->OnItemsChanged(static_cast<int>(index), 1);

msw 2016/08/12 22:19:34 nit q: can you use or [D]CHECK something from base

juncai 2016/08/15 18:11:19 Done.

+ UpdateTableView();

void ChooserContentView::OnAdapterEnabledChanged(bool enabled) {

// No row is selected since the adapter status has changed.

// This will also disable the OK button if it was enabled because