chrome/browser/chooser_controller/chooser_controller.h - Issue 2242943002: Update device name in chooser when device changes name (desktops)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chooser_controller/chooser_controller.h

Issue 2242943002: Update device name in chooser when device changes name (desktops) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated device name in chooser when device changes name Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chooser_controller/mock_chooser_controller.h » ('j') | chrome/browser/chooser_controller/mock_chooser_controller.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chooser_controller/chooser_controller.h

diff --git a/chrome/browser/chooser_controller/chooser_controller.h b/chrome/browser/chooser_controller/chooser_controller.h

index c5a3609b5377cd44fff62e24534b980e7b021967..340dbbe8ae89d8471531e42026e90b840a320833 100644

--- a/chrome/browser/chooser_controller/chooser_controller.h

+++ b/chrome/browser/chooser_controller/chooser_controller.h

@@ -46,6 +46,9 @@ class ChooserController {

// since the options have already been updated.

virtual void OnOptionRemoved(size_t index) = 0;

+ // Called when |index|th option needs to be updated.

msw 2016/08/12 22:19:33 nit: "Called when the option at |index| has been u

juncai 2016/08/15 18:11:19 Done.

+ virtual void OnOptionUpdated(size_t index) = 0;

// Called when the device adapter is turned on or off.

virtual void OnAdapterEnabledChanged(bool enabled) = 0;

« no previous file with comments | « no previous file | chrome/browser/chooser_controller/mock_chooser_controller.h » ('j') | chrome/browser/chooser_controller/mock_chooser_controller.cc » ('J')