Update device name in chooser when device changes name (desktops)

chrome/browser/ui/views/chooser_content_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/chooser_content_view.h"
 
+#include "base/numerics/safe_conversions.h"
 #include "chrome/grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/views/controls/link.h"
 #include "ui/views/controls/styled_label.h"
 #include "ui/views/controls/table/table_view.h"
 #include "ui/views/controls/throbber.h"
 #include "ui/views/layout/fill_layout.h"
 
 namespace {
 
@@ skipping 39 matching lines @@
     discovery_state_->set_listener(nullptr);
 }
 
 gfx::Size ChooserContentView::GetPreferredSize() const {
   return gfx::Size(kChooserWidth, kChooserHeight);
 }
 
 int ChooserContentView::RowCount() {
   // When there are no devices, the table contains a message saying there
   // are no devices, so the number of rows is always at least 1.
-  return std::max(static_cast<int>(chooser_controller_->NumOptions()), 1);
+  return std::max(
+      base::checked_cast<int, size_t>(chooser_controller_->NumOptions()), 1);

[Jeffrey Yasskin, 2016/08/15 21:33:53]

Don't specify the second template parameter to checked_cast. That would cause an
implicit unchecked cast to that type, followed by a checked type to the target
type, while we just want a single checked cast.

[juncai, 2016/08/15 23:53:34]

Done.

 }
 
 base::string16 ChooserContentView::GetText(int row, int column_id) {
-  int num_options = static_cast<int>(chooser_controller_->NumOptions());
+  int num_options =
+      base::checked_cast<int, size_t>(chooser_controller_->NumOptions());
   if (num_options == 0) {
     DCHECK_EQ(0, row);
     return chooser_controller_->GetNoOptionsText();
   }
 
   DCHECK_GE(row, 0);
   DCHECK_LT(row, num_options);
   return chooser_controller_->GetOption(static_cast<size_t>(row));
 }
 
 void ChooserContentView::SetObserver(ui::TableModelObserver* observer) {}
 
 void ChooserContentView::OnOptionsInitialized() {
   table_view_->OnModelChanged();
   UpdateTableView();
 }
 
 void ChooserContentView::OnOptionAdded(size_t index) {
-  table_view_->OnItemsAdded(static_cast<int>(index), 1);
+  table_view_->OnItemsAdded(base::checked_cast<int, size_t>(index), 1);
   UpdateTableView();
   table_view_->SetVisible(true);
   throbber_->SetVisible(false);
   throbber_->Stop();
 }
 
 void ChooserContentView::OnOptionRemoved(size_t index) {
-  table_view_->OnItemsRemoved(static_cast<int>(index), 1);
+  table_view_->OnItemsRemoved(base::checked_cast<int, size_t>(index), 1);
   UpdateTableView();
 }
 
+void ChooserContentView::OnOptionUpdated(size_t index) {
+  table_view_->OnItemsChanged(base::checked_cast<int, size_t>(index), 1);
+  UpdateTableView();
+}
+
 void ChooserContentView::OnAdapterEnabledChanged(bool enabled) {
   // No row is selected since the adapter status has changed.
   // This will also disable the OK button if it was enabled because
   // of a previously selected row.
   table_view_->Select(-1);
   UpdateTableView();
   table_view_->SetVisible(true);
 
   throbber_->Stop();
   throbber_->SetVisible(false);
@@ skipping 91 matching lines @@
 }
 
 void ChooserContentView::UpdateTableView() {
   if (chooser_controller_->NumOptions() == 0) {
     table_view_->OnModelChanged();
     table_view_->SetEnabled(false);
   } else {
     table_view_->SetEnabled(true);
   }
 }