Copy Page::ordinaryPages() before undeferring loads.

third_party/WebKit/Source/core/page/ScopedPageLoadDeferrer.cpp

Index: third_party/WebKit/Source/core/page/ScopedPageLoadDeferrer.cpp
diff --git a/third_party/WebKit/Source/core/page/ScopedPageLoadDeferrer.cpp b/third_party/WebKit/Source/core/page/ScopedPageLoadDeferrer.cpp
index be85168aa42537058c73dbf285db5754b4cd3d53..1f52086043d8caad3ae165f010a0d0b896440689 100644
--- a/third_party/WebKit/Source/core/page/ScopedPageLoadDeferrer.cpp
+++ b/third_party/WebKit/Source/core/page/ScopedPageLoadDeferrer.cpp
@@ -37,7 +37,10 @@ unsigned s_deferralCount = 0;
 
 void setDefersLoading(bool isDeferred)
 {
+    HeapVector<Member<Page>> pages;

[dcheng, 2016/08/15 21:57:27]

I'm not sure if it's more standard for this to be Member (since that matches
what the old RefPtr semantics would have been: this collection strongly keeps it
live) or WeakMember (to match the type of PageSet). In theory, WeakMember here
is OK: I don't think Oilpan GC can collect in the middle here, but it's seems a
bit harder to understand.

So I ended up going with Member.

[haraken, 2016/08/15 22:01:47]

HeapVector<Member<>> makes sense. We don't want to use WeakMember unless there's
any reason to do so (because of the overhead).

     for (const auto& page : Page::ordinaryPages())
+        pages.append(page);

[haraken, 2016/08/15 22:01:47]

Shall we add a comment and mention why we're copying?

[dcheng, 2016/08/15 22:34:28]

Done.

+    for (const auto& page : pages)
         page->setDefersLoading(isDeferred);
 }