Refactor LauncherDelegate

ash/launcher/app_list_launcher_item_delegate.cc

Index: ash/launcher/app_list_launcher_item_delegate.cc
diff --git a/ash/launcher/app_list_launcher_item_delegate.cc b/ash/launcher/app_list_launcher_item_delegate.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9e269566e7915aa085c22abc4447a33e431b4a47
--- /dev/null
+++ b/ash/launcher/app_list_launcher_item_delegate.cc
@@ -0,0 +1,61 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/launcher/app_list_launcher_item_delegate.h"
+
+#include "ash/launcher/launcher_model.h"
+#include "ash/shell.h"
+#include "ash/shell_delegate.h"
+#include "grit/ash_strings.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace ash {
+namespace internal {
+
+AppListLauncherItemDelegate::AppListLauncherItemDelegate() {
+// TODO: Create AppList LauncherItem here.

[Mr4D (OOO till 08-26), 2013/08/14 15:52:19]

Just thinking - couldn't this be created as all the other LauncherItemDelegates
in the realm of the browser and thus removing the need for this proxy/dispatch
class altogether? That would be far cleaner and better understandable.

[simonhong_, 2013/08/14 23:47:51]

Proxy/dispatch class is introduced for dialog launcher item (TaskManager).
Its item is handled only in ash(by LauncherItemManager - implemented in adding
TaskManager CL)
To handle request from Launcher/LauncherView for dialog item,
LauncherItemManager need a LauncherDelegate interface.
After some thinking, I think LauncherItemManager don't need whole the
LauncherDelegate interface,
it only need LauncherItem specific bits of LauncherDelegate(interfaces in
LauncherItemDelegate).
Sky also agreed that design and requested doing this refactoring in the separate
CL(this CL).
During the refactoring, AppListLauncherItemDelegate is introduced prior to
adding LaunherItemDelegate for dialog item(It will added in another CL)

[Mr4D (OOO till 08-26), 2013/08/15 15:53:19]

Okay - so more are coming, but that somehow does not mean that this has to be
within ash?

What LauncherItemManager?

+}
+
+AppListLauncherItemDelegate::~AppListLauncherItemDelegate() {
+}
+
+void AppListLauncherItemDelegate::ItemSelected(const LauncherItem& item,
+                                               const ui::Event& event) {
+  // Passing NULL to ToggleAppList() can show app list on the right shelf
+  // because when LauncherItem is selected target root window is set to active
+  // root window.
+  Shell::GetInstance()->ToggleAppList(NULL);
+}
+
+base::string16 AppListLauncherItemDelegate::GetTitle(const LauncherItem& item) {
+  LauncherModel* model = Shell::GetInstance()->launcher_model();
+  DCHECK(model);
+  return model->status() == LauncherModel::STATUS_LOADING ?
+      l10n_util::GetStringUTF16(IDS_AURA_APP_LIST_SYNCING_TITLE) :
+      l10n_util::GetStringUTF16(IDS_AURA_APP_LIST_TITLE);
+}
+
+ui::MenuModel* AppListLauncherItemDelegate::CreateContextMenu(
+    const LauncherItem& item,
+    aura::RootWindow* root_window) {
+  return NULL;
+}
+
+LauncherMenuModel* AppListLauncherItemDelegate::CreateApplicationMenu(
+    const LauncherItem& item,
+    int event_flags) {
+  // AppList don't show application menu.
+  return NULL;
+}
+
+bool AppListLauncherItemDelegate::IsDraggable(const LauncherItem& item) {
+  return false;
+}
+
+bool AppListLauncherItemDelegate::ShouldShowTooltip(const LauncherItem& item) {
+  return true;
+}
+
+}  // namespace internal
+}  // namespace ash