Refactor LauncherDelegate

ash/launcher/ash_launcher_delegate.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_LAUNCHER_ASH_LAUNCHER_DELEGATE_H_
+#define ASH_LAUNCHER_ASH_LAUNCHER_DELEGATE_H_
+
+#include "ash/launcher/launcher_delegate.h"
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+
+namespace ash {
+class Launcher;
+class LauncherItemDelegate;
+
+namespace internal {
+
+// LauncherDelegate in Ash.

[Mr4D (OOO till 08-26), 2013/08/14 15:52:19]

IF there is a reason to not follow my comment in
app_list_launcher_item_delegate.cc:

This is confusing. Why are you not simply putting the 2 needed lines of this
class into your "Proxy" class and rename the "Proxy" class into something like
"LauncherDelegateDispatcher" or so? That would make it much easier to understand
what is going on here.

[simonhong_, 2013/08/14 23:47:51]

The reason why I another LauncherDelegate in Ash is GetIDByWindow().
Most of other interfaces are only served by ChromeLauncherDelegate.
So I also thought that LauncherDelegateProxy just return ItemDelegate of applist
or dialog
not via AshLauncherDelegate.
Of course GetIDByWindow() can search by using pointer of each ItemController in
ash.
But, I think doing this via LauncherDelegate is more cleaner design.
I assume that AshLauncherDelegate get more role in the future.
Which is more better approach?

[Mr4D (OOO till 08-26), 2013/08/15 15:53:19]

If it is only the one function you are interested in: Wouldn't it be better to
have a central registration place which can "register" a handler (and which
could be queried then)? Something like "AddGetIDByWindowHandler(..)". That way
the LauncherDelegate could then query all known handlers and return an ID.

+class AshLauncherDelegate : public LauncherDelegate {
+ public:
+  AshLauncherDelegate();
+  virtual ~AshLauncherDelegate();
+
+  // ash::LauncherDelegate overrides;
+  virtual LauncherID GetIDByWindow(aura::Window* window) OVERRIDE;
+  virtual void OnLauncherCreated(Launcher* launcher) OVERRIDE;
+  virtual void OnLauncherDestroyed(Launcher* launcher) OVERRIDE;
+  virtual LauncherID GetLauncherIDForAppID(const std::string& app_id) OVERRIDE;
+  virtual void PinAppWithID(const std::string& app_id) OVERRIDE;
+  virtual bool IsAppPinned(const std::string& app_id) OVERRIDE;
+  virtual void UnpinAppsWithID(const std::string& app_id) OVERRIDE;
+  virtual LauncherItemDelegate* GetLauncherItemDelegate(
+      const LauncherItem& item) OVERRIDE;
+
+ private:
+  scoped_ptr<LauncherItemDelegate> app_list_item_delegate_;
+
+  DISALLOW_COPY_AND_ASSIGN(AshLauncherDelegate);
+};
+
+}  // namespace internal
+}  // namespace ash
+
+#endif  // ASH_LAUNCHER_ASH_LAUNCHER_DELEGATE_H_