Fix resolveRelativeUri() to handle correctly empty contained Uri(s).

Fix resolveRelativeUri() to handle correctly empty contained Uri(s).

This was breaking linking with `package` Uri(s).
I also added a new test that exhibits this behaviour.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/df4baa4332e904bf289381039d2076c8b8ab3299

[Brian Wilkerson, 2016-08-12 17:15:13]

lgtm

[Paul Berry, 2016-08-12 17:51:18]

lgtm, however I'm surprised it was necessary to change resolveRelativeUri() in
order to get the linker test to pass.  Would it perhaps be better to make a fix
to the linker so that it doesn't try to send an empty string to
resolveRelativeUri()?

https://codereview.chromium.org/2242883003/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/2242883003/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:4447: Uri base =
Uri.parse(baseStr);
I'm curious what the motivation was for using Uri.parse instead of
parseUriWithException (as the code previously did)

[scheglov, 2016-08-12 17:58:06]

Uri.resolveUri() already handles empty contained Uri(s) this way.
We just fix resolveRelativeUri() to special handle only "dart:" URIs.

https://codereview.chromium.org/2242883003/diff/1/pkg/analyzer/test/generated...
File pkg/analyzer/test/generated/all_the_rest_test.dart (right):

https://codereview.chromium.org/2242883003/diff/1/pkg/analyzer/test/generated...
pkg/analyzer/test/generated/all_the_rest_test.dart:4447: Uri base =
Uri.parse(baseStr);
On 2016/08/12 17:51:18, Paul Berry wrote:
> I'm curious what the motivation was for using Uri.parse instead of
> parseUriWithException (as the code previously did)

To allow parsing empty Uri.

[scheglov, 2016-08-12 17:59:39]

Description was changed from

==========
Fix resolveRelativeUri() to handle correctly empty contained Uri(s).

This was breaking linking with `package` Uri(s).
I also added a new test that exhibits this behaviour.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Fix resolveRelativeUri() to handle correctly empty contained Uri(s).

This was breaking linking with `package` Uri(s).
I also added a new test that exhibits this behaviour.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/df4baa4332e904bf289381039d2076c8b8ab3299
==========

[scheglov, 2016-08-12 17:59:40]

Committed patchset #1 (id:1) manually as
df4baa4332e904bf289381039d2076c8b8ab3299 (presubmit successful).