Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2242873002: [MD User Menu] New profile badge icons (Closed)

Created:
4 years, 4 months ago by Jane
Modified:
4 years, 4 months ago
Reviewers:
*sky, *Evan Stade
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD User Menu] New profile badge icons Added new profile badge icons (i.e. supervised icon and child icon) for MD user menu. The new icons are inverted inside a circle to save unnecessary drawing steps on the run and to follow the new color spec for the icons. Mock (icon doesn't look exactly the same): https://folio.googleplex.com/chrome-ux-specs-and-sources/Chrome%20Desktop%20Sign%20In/user_menu/preview#%2Fpreview-2.png Screenshot: https://drive.google.com/a/google.com/file/d/0B7Fvv7JszRyGZHVOdndlNXFxWXc/view?usp=sharing BUG=615893 Committed: https://crrev.com/d5141f56dc92d1400988bfabb5170dd48731ee4f Cr-Commit-Position: refs/heads/master@{#411963}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added f to avoid WIN failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -44 lines) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 3 chunks +21 lines, -20 lines 0 comments Download
A + ui/gfx/vector_icons/account_child.icon View 0 chunks +-1 lines, --1 lines 0 comments Download
A ui/gfx/vector_icons/account_child_circle.icon View 1 1 chunk +36 lines, -0 lines 0 comments Download
D ui/gfx/vector_icons/account_child_invert.icon View 1 chunk +0 lines, -24 lines 0 comments Download
A ui/gfx/vector_icons/supervisor_account_circle.icon View 1 chunk +38 lines, -0 lines 0 comments Download
M ui/gfx/vector_icons_sources.gypi View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 26 (15 generated)
Jane
Hi Evan, I finally got the new profile badge resources! PTAL, thanks!
4 years, 4 months ago (2016-08-12 15:47:00 UTC) #4
Evan Stade
lgtm
4 years, 4 months ago (2016-08-12 18:49:14 UTC) #5
Jane
Thanks!
4 years, 4 months ago (2016-08-12 18:50:00 UTC) #8
sky
LGTM
4 years, 4 months ago (2016-08-12 21:41:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242873002/1
4 years, 4 months ago (2016-08-12 21:43:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/238495)
4 years, 4 months ago (2016-08-12 22:31:15 UTC) #13
Evan Stade
https://codereview.chromium.org/2242873002/diff/1/ui/gfx/vector_icons/account_child_circle.icon File ui/gfx/vector_icons/account_child_circle.icon (right): https://codereview.chromium.org/2242873002/diff/1/ui/gfx/vector_icons/account_child_circle.icon#newcode6 ui/gfx/vector_icons/account_child_circle.icon:6: CIRCLE, 12, 13.49, 1.5, you need f
4 years, 4 months ago (2016-08-15 13:36:15 UTC) #14
Jane
https://codereview.chromium.org/2242873002/diff/1/ui/gfx/vector_icons/account_child_circle.icon File ui/gfx/vector_icons/account_child_circle.icon (right): https://codereview.chromium.org/2242873002/diff/1/ui/gfx/vector_icons/account_child_circle.icon#newcode6 ui/gfx/vector_icons/account_child_circle.icon:6: CIRCLE, 12, 13.49, 1.5, On 2016/08/15 13:36:15, Evan Stade ...
4 years, 4 months ago (2016-08-15 14:36:23 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242873002/20001
4 years, 4 months ago (2016-08-15 14:37:12 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-15 14:40:44 UTC) #24
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 14:44:24 UTC) #26
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5141f56dc92d1400988bfabb5170dd48731ee4f
Cr-Commit-Position: refs/heads/master@{#411963}

Powered by Google App Engine
This is Rietveld 408576698