pkg/analyzer/tool/summary/build_sdk_summaries.dart - Issue 2242853002: Deprecate DirectoryBasedDartSdk and transition existing uses to the new API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/tool/summary/build_sdk_summaries.dart

Issue 2242853002: Deprecate DirectoryBasedDartSdk and transition existing uses to the new API (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/server/driver.dart ('K') | « pkg/analyzer/test/stress/for_git_repository.dart ('k') | pkg/analyzer/tool/task_dependency_graph/generate.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/tool/summary/build_sdk_summaries.dart

diff --git a/pkg/analyzer/tool/summary/build_sdk_summaries.dart b/pkg/analyzer/tool/summary/build_sdk_summaries.dart

index bf6d8b5b080d4559c87044929a014eb9935cdd24..8a6645d11c79dce53942b844781669f452b32d6d 100644

--- a/pkg/analyzer/tool/summary/build_sdk_summaries.dart

+++ b/pkg/analyzer/tool/summary/build_sdk_summaries.dart

@@ -1,6 +1,7 @@

import 'dart:io';

-import 'package:analyzer/src/generated/sdk_io.dart';

+import 'package:analyzer/file_system/physical_file_system.dart';

+import 'package:analyzer/src/dart/sdk/sdk.dart';

import 'package:analyzer/src/summary/flat_buffers.dart' as fb;

import 'package:analyzer/src/summary/summary_file_builder.dart';

@@ -98,7 +99,9 @@ SummaryOutput _buildMultipleOutputs(String sdkPath, bool includeSpec) {

return null;

}

} else {

- sdkPath = DirectoryBasedDartSdk.defaultSdkDirectory.getAbsolutePath();

+ sdkPath = FolderBasedDartSdk

+ .defaultSdkDirectory(PhysicalResourceProvider.INSTANCE)

+ .path;

}