Refactoring functions in metrics/smoothness.py

Refactoring functions in metrics/smoothness.py

BUG=

[qyearsley, 2013-08-06 23:47:07]

The main change was factoring out two functions, which are used by several of
the Calc* functions: _AddDeltaResult,  _AddAverageTimeResult.

The goal is to try to improve readability.  Also, the variable names used before
were CapitalCamelCase whereas it seems the style guide suggests
lower_with_underscores for variables.

The behavior should be the same as before. I ran the smoothness metric before
and after and briefly looked at the output, and there seemed to be no
difference.

[qyearsley, 2013-08-06 23:49:40]

On 2013/08/06 23:47:07, qyearsley wrote:
> The main change was factoring out two functions, which are used by several of
> the Calc* functions: _AddDeltaResult,  _AddAverageTimeResult.
> 
> The goal is to try to improve readability.  Also, the variable names used
before
> were CapitalCamelCase whereas it seems the style guide suggests
> lower_with_underscores for variables.
> 
> The behavior should be the same as before. I ran the smoothness metric before
> and after and briefly looked at the output, and there seemed to be no
> difference.

Later, when the Calc* functions are changed to become private methods that are
used by AddResults (and renamed to _Add*), they could also be simplified by
making them a nested inside of AddResults, and then the "deltas" and "results"
arguments wouldn't need to be passed to each of these functions...