Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2242773002: Enable bookmark suggestions by default (Closed)

Created:
4 years, 4 months ago by jkrcal
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, Patrick Nepper
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable bookmark suggestions by default BUG=629015 Committed: https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c Cr-Commit-Position: refs/heads/master@{#411591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/ntp_snippets/features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jkrcal
Bernhard, PTAL. It is still guarded by the "main" zine feature which is off-by-default. I ...
4 years, 4 months ago (2016-08-12 09:44:16 UTC) #2
Bernhard Bauer
lgtm
4 years, 4 months ago (2016-08-12 09:45:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242773002/1
4 years, 4 months ago (2016-08-12 09:46:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-12 10:42:18 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 10:44:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f86c8b09a35bf827144214afec1c456415c4d24c
Cr-Commit-Position: refs/heads/master@{#411591}

Powered by Google App Engine
This is Rietveld 408576698