third_party/WebKit/Source/core/dom/ExecutionContext.h - Issue 2242743002: Make custom elements work in HTML imports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ExecutionContext.h

Issue 2242743002: Make custom elements work in HTML imports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clean up tests, remove redundant cases Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/custom-elements/imports/upgrade-order.html ('K') | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElement.cpp » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ExecutionContext.h

diff --git a/third_party/WebKit/Source/core/dom/ExecutionContext.h b/third_party/WebKit/Source/core/dom/ExecutionContext.h

index 436bb4577f989d4ef781baf10a4af29f040ab28e..ca79caee6c5d6c278719340516b0eef2a105594f 100644

--- a/third_party/WebKit/Source/core/dom/ExecutionContext.h

+++ b/third_party/WebKit/Source/core/dom/ExecutionContext.h

@@ -88,7 +88,7 @@ public:

const KURL& url() const;

KURL completeURL(const String& url) const;

virtual void disableEval(const String& errorMessage) = 0;

- virtual LocalDOMWindow* executingWindow() { return 0; }

+ virtual LocalDOMWindow* executingWindow() const { return 0; }

virtual String userAgent() const = 0;

virtual void postTask(const WebTraceLocation&, std::unique_ptr<ExecutionContextTask>, const String& taskNameForInstrumentation = emptyString()) = 0; // Executes the task on context's thread asynchronously.