third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.h - Issue 2242743002: Make custom elements work in HTML imports

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.h

Issue 2242743002: Make custom elements work in HTML imports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: wip (CustomElementsRegistry.cpp change is gone) Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp ('K') | « third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp » ('j') | third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.h

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.h b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.h

index 5892539ba02421d0b3354d8f9fbe827b38b8bd2d..89d4e0d8b42fe1dadea02c705085fa7b3244863d 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.h

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementUpgradeSorter.h

@@ -34,6 +34,12 @@ private:

using ChildSet = HeapHashSet<Member<Node>>;

using ParentChildMap = HeapHashMap<Member<Node>, ChildSet>;

+ enum AddResult {

dominicc (has gone to gerrit) 2016/08/22 12:05:58 I think the enum result you have here, and pulling

kochi 2016/08/22 15:56:30 Thanks!

+ kParentAlreadyExistsInMap,

+ kParentAddedToMap

+ };

+ AddResult addToParentChildMap(Node* parent, Node* child);

void visit(

HeapVector<Member<Element>>* result,

ChildSet&,