third_party/WebKit/LayoutTests/custom-elements/imports/imports-and-synchronous-create.html - Issue 2242743002: Make custom elements work in HTML imports

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/custom-elements/imports/imports-and-synchronous-create.html

Issue 2242743002: Make custom elements work in HTML imports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolve most comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 'use strict';
	kochi 2016/08/22 07:37:35 Conversion to async-style is not yet done for this Conversion to async-style is not yet done for this file.
	6 setup({ explicit_done: true });

	7 let reactions = [];

	8 customElements.define('x-x', class extends HTMLElement {

	9 constructor() {

	10 super();

	11 reactions.push({ type: 'constructor', element: this });

	12 }

	13 });

	14 test(() => {

	15 assert_equals(reactions.length, 0);

	16 }, 'Should not have parsed <x-x> yet');

	17 </script>

	18

	19 <x-x></x-x>

	20

	21 <script>

	22 'use strict';

	23 test(() => {

	24 assert_equals(reactions.length, 1);

	25 }, 'Parser should invoke the custom element constructor');

	26

	27 let import1 = document.createElement('link');

	28 import1.rel = 'import';

	29 import1.href = 'resources/import-custom.html';

	30 document.head.appendChild(import1);

	31

	32 import1.onload = () => {

	33 test(() => {

	34 assert_equals(reactions.length, 2);

	35 }, 'import should invoke the custom element constructor');

	36

	37 let elementsInMaster = document.getElementsByTagName('x-x');

	38 let elementsInImport = import1.import.getElementsByTagName('x-x');

	39 test(() => {

	40 assert_equals(reactions[0].element, elementsInMaster[0]);

	41 assert_equals(reactions[1].element, elementsInImport[0]);

	42 }, 'Constructor should run in the order elements are created');

	43

	44 done();

	45 };

	46 </script>

OLD	NEW