third_party/WebKit/LayoutTests/custom-elements/imports/imports-define-in-import.html - Issue 2242743002: Make custom elements work in HTML imports

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/custom-elements/imports/imports-define-in-import.html

Issue 2242743002: Make custom elements work in HTML imports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <link id="import1" rel="import" href="resources/import-define.html" />

	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <x-x></x-x>

	6 <script>

	7 'use strict'

	8 setup({ explicit_done: true });

	9 window.onload = function () {

	10 test(() => {

	11 assert_equals(reactions.length, 2);

	12 }, 'Upgrade elements in master and import');

	13

	14 let elementsInMaster = document.getElementsByTagName('x-x');

	15 let elementsInImport = import1.import.getElementsByTagName('x-x');

	16 test(() => {

	17 assert_equals(reactions[0].element, elementsInImport[0]);
	dominicc (has gone to gerrit) 2016/08/22 01:46:36 I think I have mentioned this a few times, but sim I think I have mentioned this a few times, but simpler array contents and assert_array_equals would make these tests easier to understand. kochi 2016/08/22 07:37:34 Done. Show quoted text On 2016/08/22 01:46:36, dominicc wrote: > I think I have mentioned this a few times, but simpler array contents and > assert_array_equals would make these tests easier to understand. Done.
	18 assert_equals(reactions[1].element, elementsInMaster[0]);

	19 }, 'Upgrade elements in import first');

	20

	21 done();

	22 };

	23 </script>

OLD	NEW