third_party/WebKit/LayoutTests/custom-elements/imports/circular-imports.html - Issue 2242743002: Make custom elements work in HTML imports

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/custom-elements/imports/circular-imports.html

Issue 2242743002: Make custom elements work in HTML imports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 'use strict';

	6 let constructors = [];

	7 </script>

	8 <a-a></a-a>

	9 <b-b></b-b>

	10 <link rel="import" href="resources/circular-level1.html">

	11 <script>

	12 'use strict';

	13 test(() => {

	14 // At the point of imports, <a-a> and <b-b> are already parsed and will be

	15 // upgraded upon definition is ready.
	dominicc (has gone to gerrit) 2016/08/22 01:46:36 grammar: upon ... is ready maybe "when the" inste grammar: upon ... is ready maybe "when the" instead of "upon" is easy to read and makes sense grammar: definition is -> definitions are there are two different kinds of elements, so there must be two definitions? Singular "is" is confusing here. kochi 2016/08/22 07:37:34 Done. Show quoted text On 2016/08/22 01:46:36, dominicc wrote: > grammar: upon ... is ready > > maybe "when the" instead of "upon" is easy to read and makes sense > > grammar: definition is -> definitions are > > there are two different kinds of elements, so there must be two definitions? > Singular "is" is confusing here. Done.
	16 assert_array_equals(constructors, ['circular-level2', 'circular-level1'],

	17 'The constructor order should be script execution order of definition.');

	18 }, 'Custom Elements definitions in circularly-dependent imports should work.');

	19 </script>

OLD	NEW