third_party/WebKit/LayoutTests/custom-elements/imports/async-nested-imports.html - Issue 2242743002: Make custom elements work in HTML imports

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/custom-elements/imports/async-nested-imports.html

Issue 2242743002: Make custom elements work in HTML imports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/custom-elements/imports/async-imports.html ('K') | « third_party/WebKit/LayoutTests/custom-elements/imports/async-imports.html ('k') | third_party/WebKit/LayoutTests/custom-elements/imports/circular-imports.html » ('j') | third_party/WebKit/LayoutTests/custom-elements/imports/circular-imports.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <script>

	5 'use strict';

	6 let constructors = [];

	7 </script>

	8 <link rel="import" href="resources/async-nested-component.html" async>

	9 <script>

	10 'use strict';

	11 setup({ explicit_done: true });
	dominicc (has gone to gerrit) 2016/08/22 01:46:36 I think async_test is better than explicit done. a I think async_test is better than explicit done. async_test is more flexible--it can coordinating multiple tests in the one file; you can use the event watcher; etc. kochi 2016/08/22 07:37:34 Done. Show quoted text On 2016/08/22 01:46:36, dominicc wrote: > I think async_test is better than explicit done. async_test is more flexible--it > can coordinating multiple tests in the one file; you can use the event watcher; > etc. Done.
	12

	13 let link = document.querySelector('link[rel=import]');

	14 link.onload = () => {

	15 test(() => {

	16 let n1 = link.import.querySelector('a-a');

	17 let n2 = link.import.querySelector('b-b');

	18 let n3 = link.import.querySelector('c-c');

	19

	20 assert_true(n1 instanceof NestedLevel1, 'nested-level1 in import should be c ustom');

	21 assert_true(n2 instanceof NestedLevel2, 'nested-level2 in import should be c ustom');

	22 assert_true(n3 instanceof NestedLevel3, 'nested-level3 in import should be c ustom');

	23

	24 // As subimports are sync, the upgrade order should be the order of script e xecution.

	25 let types = constructors.map(e => e.type);

	26 assert_array_equals(types, ['nested-level3', 'nested-level2', 'nested-level1 ']);

	27 }, 'top-level async import should properly run dependent subimports and get el ements defined.');

	28 done();

	29 }

	30 </script>

OLD	NEW