third_party/WebKit/LayoutTests/custom-elements/imports/async-imports.html - Issue 2242743002: Make custom elements work in HTML imports

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/custom-elements/imports/async-imports.html

Issue 2242743002: Make custom elements work in HTML imports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/custom-elements/imports/async-nested-imports.html » ('j') | third_party/WebKit/LayoutTests/custom-elements/imports/async-nested-imports.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <link rel="import" href="resources/async-component.html" async>

	5 <async-component></async-component>

	6 <script>

	7 'use strict';

	8 promise_test(() => {

	9 return customElements.whenDefined('async-component').then(() => {

	10 let el = document.querySelector('async-component');
	dominicc (has gone to gerrit) 2016/08/22 01:46:36 'el' is kind of neither here nor there; the name c 'el' is kind of neither here nor there; the name could be shorter (like just 'a' or 'e') or it could be a word like 'element'. 'elInImport' is weird because it mixes abbreviated and unabbreviated things. Maybe go for el => a elInImport => b and have the assertion messages explain the "in import" part. kochi 2016/08/22 07:37:34 Done. Show quoted text On 2016/08/22 01:46:36, dominicc wrote: > 'el' is kind of neither here nor there; the name could be shorter (like just 'a' > or 'e') or it could be a word like 'element'. 'elInImport' is weird because it > mixes abbreviated and unabbreviated things. Maybe go for > > el => a > elInImport => b > > and have the assertion messages explain the "in import" part. Done.
	11 assert_true(el instanceof AsyncComponent,
	dominicc (has gone to gerrit) 2016/08/22 01:46:36 In a lot of tests we assert something has been upg In a lot of tests we assert something has been upgraded, but we do it differently everywhere. Maybe add a helper assert_is_upgraded and use that everywhere. Maybe put a TODO on it to make everywhere do it. That could assert: - not just instanceof, but exact prototype match. - matches :defined kochi 2016/08/22 07:37:34 Done. Show quoted text On 2016/08/22 01:46:36, dominicc wrote: > In a lot of tests we assert something has been upgraded, but we do it > differently everywhere. > > Maybe add a helper assert_is_upgraded and use that everywhere. Maybe put a TODO > on it to make everywhere do it. > > That could assert: > - not just instanceof, but exact prototype match. > - matches :defined Done.
	12 '<async-component> in this document should have been upgraded.') ;

	13

	14 let link = document.querySelector('link[rel=import]');

	15 let elInImport = link.import.querySelector('async-component');

	16 assert_true(elInImport instanceof AsyncComponent,

	17 '<async-component> in imported document should have been upgrade d.');

	18 });

	19 }, 'Custom Elements definition in async import should work.');

	20 </script>

OLD	NEW