third_party/WebKit/LayoutTests/custom-elements/imports/async-imports.html - Issue 2242743002: Make custom elements work in HTML imports

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/custom-elements/imports/async-imports.html

Issue 2242743002: Make custom elements work in HTML imports (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase wip Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/custom-elements/imports/async-nested-imports.html » ('j') | third_party/WebKit/LayoutTests/custom-elements/imports/async-nested-imports.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <link rel="import" href="resources/async-component.html" async>

	5 <async-component></async-component>

	6 <script>

	7 'use strict';

	8

	9 promise_test(() => {

	10 return customElements.whenDefined('async-component').then(() => {

	11 let el = document.querySelector('async-component');

	12 assert_true(el instanceof AsyncComponent, 'async-component should be custom' );
	dominicc (has gone to gerrit) 2016/08/19 04:54:10 "be custom" is a bit vague; can you be more specif "be custom" is a bit vague; can you be more specific about what instanceof AsyncComponent implies? kochi 2016/08/19 10:51:47 I rewrote where appropriate, but "be custom" is ok Show quoted text On 2016/08/19 04:54:10, dominicc wrote: > "be custom" is a bit vague; can you be more specific about what instanceof > AsyncComponent implies? I rewrote where appropriate, but "be custom" is okay, if it means "the custom element state is custom"? https://dom.spec.whatwg.org/#concept-element-custom And I think checking if the constructor for that element is called is more complete for that purpose.
	13

	14 let link = document.querySelector('link[rel=import]');

	15 let elInImport = link.import.querySelector('async-component');

	16 assert_true(elInImport instanceof AsyncComponent, 'async-component in import should be custom');

	17 });

	18 }, 'Custom Elements v1 definition in async import should work.');
	dominicc (has gone to gerrit) 2016/08/19 04:54:10 Just refer to these as "custom elements"; not "v1. Just refer to these as "custom elements"; not "v1." When we delete v0 there will be one and only custom elements and we can forget this version thing ever existed. kochi 2016/08/19 10:51:47 Done. Show quoted text On 2016/08/19 04:54:10, dominicc wrote: > Just refer to these as "custom elements"; not "v1." When we delete v0 there will > be one and only custom elements and we can forget this version thing ever > existed. Done.
	19 </script>

OLD	NEW