Issue 224273002: Revert of [Android] Provide unhandled tap event notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 224273002: Revert of [Android] Provide unhandled tap event notifications (Closed)

Created:
6 years, 8 months ago by jdduke (slow)

Modified:
6 years, 8 months ago

Reviewers:
Ted C, Donn Denman, mkosiba (inactive)

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Revert of [Android] Provide unhandled tap event notifications (https://codereview.chromium.org/218633008/) Reason for revert: Legitimate browsertest failure. Original issue's description: > [Android] Provide unhandled tap event notifications > > Allow notifications of unhandled taps via the GestureStateListener. This change > makes GestureTap events blocking, but there are several use-cases for which this > will be necessary, e.g., WebView and contextual search. > > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261431 TBR=mkosiba@chromium.org,donnd@chromium.org,tedchoc@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261470

Created: 6 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -30 lines)			Patch
M	content/browser/android/content_view_core_impl.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/input/input_router_impl_unittest.cc	View	2 chunks	+3 lines, -10 lines	0 comments	Download
M	content/common/input/web_input_event_traits.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content_public/browser/GestureStateListener.java	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

jdduke (slow)

Created Revert of [Android] Provide unhandled tap event notifications

6 years, 8 months ago (2014-04-03 17:45:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/224273002/1

6 years, 8 months ago (2014-04-03 17:46:38 UTC) #2

Message was sent while issue was closed.

Change committed as 261470