Avoid an undefined shift in ReadPageHintTable().

Avoid an undefined shift in ReadPageHintTable().

Even 39 bits is very generous for the number of bits needed to represent
the greatest number of shared object references.

BUG=637119
Committed: https://pdfium.googlesource.com/pdfium/+/9fe6f3ad47ca099efe5ae18aabfae6594a1e0329

[Lei Zhang, 2016-08-12 03:52:31]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-12 03:52:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-12 04:04:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-12 04:04:04]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-12 04:06:33]

Description was changed from

==========
Check for undefined shift in ReadPageHintTable().

Even 40 bits is very generous for the number of bits needed to represent
the greatest number of shared object references.

BUG=637119
==========

to

==========
Avoid an undefined shift in ReadPageHintTable().

Even 40 bits is very generous for the number of bits needed to represent
the greatest number of shared object references.

BUG=637119
==========

[Lei Zhang, 2016-08-12 04:06:33]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-08-12 15:29:12]

lgtm

https://codereview.chromium.org/2242723002/diff/1/core/fpdfapi/fpdf_parser/cp...
File core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp (right):

https://codereview.chromium.org/2242723002/diff/1/core/fpdfapi/fpdf_parser/cp...
core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp:112: if (dwSharedObjBits >= 40)
nit: can we make this kMumbleSomethingBits add add the comment about generosity
when we declare it?

[Lei Zhang, 2016-08-13 02:43:53]

Description was changed from

==========
Avoid an undefined shift in ReadPageHintTable().

Even 40 bits is very generous for the number of bits needed to represent
the greatest number of shared object references.

BUG=637119
==========

to

==========
Avoid an undefined shift in ReadPageHintTable().

Even 39 bits is very generous for the number of bits needed to represent
the greatest number of shared object references.

BUG=637119
==========

[Lei Zhang, 2016-08-13 02:47:14]

https://codereview.chromium.org/2242723002/diff/1/core/fpdfapi/fpdf_parser/cp...
File core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp (right):

https://codereview.chromium.org/2242723002/diff/1/core/fpdfapi/fpdf_parser/cp...
core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp:112: if (dwSharedObjBits >= 40)
On 2016/08/12 15:29:12, Tom Sepez wrote:
> nit: can we make this kMumbleSomethingBits add add the comment about
generosity
> when we declare it?

Done.

[Lei Zhang, 2016-08-13 02:47:27]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-08-13 02:47:28]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2242723002/#ps20001
(title: "constant, comment")

[commit-bot: I haz the power, 2016-08-13 02:47:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-13 03:00:37]

Description was changed from

==========
Avoid an undefined shift in ReadPageHintTable().

Even 39 bits is very generous for the number of bits needed to represent
the greatest number of shared object references.

BUG=637119
==========

to

==========
Avoid an undefined shift in ReadPageHintTable().

Even 39 bits is very generous for the number of bits needed to represent
the greatest number of shared object references.

BUG=637119

Committed:
https://pdfium.googlesource.com/pdfium/+/9fe6f3ad47ca099efe5ae18aabfae6594a1e...
==========

[commit-bot: I haz the power, 2016-08-13 03:00:38]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/9fe6f3ad47ca099efe5ae18aabfae6594a1e...