Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2242703002: Fix frameset within fragment asserts in HTMLTreeBuilder (Closed)

Created:
4 years, 4 months ago by Charlie Harrison
Modified:
4 years, 4 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, kinuko+watch, loading-reviews+parser_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix frameset within fragment asserts in HTMLTreeBuilder The HTMLTreeBuilder does not expect a frameset within a fragment in the "in body" insertion mode. It seems like this is not specifically disallowed in the spec, event though there are other cases where the algorithm aborts here due to parsing a fragment. https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody BUG=636057 Committed: https://crrev.com/681c95bfedb5ee83897f8a0d4104c91049ba16f6 Cr-Commit-Position: refs/heads/master@{#411945}

Patch Set 1 #

Patch Set 2 : clean up asserts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/parser/frameset-in-fragment.html View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 18 (13 generated)
Charlie Harrison
Reading the spec, "(fragment case)" is after cases where we *must* be in fragment case ...
4 years, 4 months ago (2016-08-12 15:04:09 UTC) #9
kouhei (in TOK)
lgtm
4 years, 4 months ago (2016-08-15 05:22:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242703002/20001
4 years, 4 months ago (2016-08-15 05:22:17 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-15 07:09:01 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 07:11:15 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/681c95bfedb5ee83897f8a0d4104c91049ba16f6
Cr-Commit-Position: refs/heads/master@{#411945}

Powered by Google App Engine
This is Rietveld 408576698