Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2242623002: Remove obsolete QUIC Compressed Cert Set v1. (Closed)

Created:
4 years, 4 months ago by Ryan Hamilton
Modified:
4 years, 4 months ago
Reviewers:
Zhongyi Shi, Torne
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete QUIC Compressed Cert Set v1. Merge internal change: 130089774 BUG=636423 Committed: https://crrev.com/aa7a8e79bcfc1680fabf697c9f473e8e7908ccaa Cr-Commit-Position: refs/heads/master@{#411744}

Patch Set 1 : Trying again #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13142 lines) Patch
M net/quic/core/crypto/common_cert_set.cc View 1 3 chunks +1 line, -10 lines 0 comments Download
D net/quic/core/crypto/common_cert_set_1.c View 1 1 chunk +0 lines, -145 lines 0 comments Download
D net/quic/core/crypto/common_cert_set_1a.inc View 1 1 chunk +0 lines, -10166 lines 0 comments Download
D net/quic/core/crypto/common_cert_set_1b.inc View 1 1 chunk +0 lines, -2711 lines 0 comments Download
M net/quic/core/crypto/common_cert_set_test.cc View 1 3 chunks +2 lines, -108 lines 0 comments Download
M tools/copyright_scanner/third_party_files_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 34 (23 generated)
Ryan Hamilton
4 years, 4 months ago (2016-08-11 21:55:07 UTC) #3
Zhongyi Shi
https://codereview.chromium.org/2242623002/diff/1/net/quic/core/crypto/common_cert_set_1a.inc File net/quic/core/crypto/common_cert_set_1a.inc (left): https://codereview.chromium.org/2242623002/diff/1/net/quic/core/crypto/common_cert_set_1a.inc#oldcode5 net/quic/core/crypto/common_cert_set_1a.inc:5: Looks like this file will only contain the license ...
4 years, 4 months ago (2016-08-11 23:05:00 UTC) #7
Ryan Hamilton
cleanup
4 years, 4 months ago (2016-08-11 23:28:33 UTC) #8
Ryan Hamilton
Thanks. https://codereview.chromium.org/2242623002/diff/1/net/quic/core/crypto/common_cert_set_1a.inc File net/quic/core/crypto/common_cert_set_1a.inc (left): https://codereview.chromium.org/2242623002/diff/1/net/quic/core/crypto/common_cert_set_1a.inc#oldcode5 net/quic/core/crypto/common_cert_set_1a.inc:5: On 2016/08/11 23:05:00, Zhongyi Shi wrote: > Looks ...
4 years, 4 months ago (2016-08-11 23:29:29 UTC) #9
Zhongyi Shi
lgtm
4 years, 4 months ago (2016-08-12 00:04:01 UTC) #12
Torne
copyright scanner whitelist LGTM
4 years, 4 months ago (2016-08-12 17:48:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242623002/40002
4 years, 4 months ago (2016-08-12 18:00:50 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/111710)
4 years, 4 months ago (2016-08-12 18:27:58 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2242623002/40002
4 years, 4 months ago (2016-08-12 19:16:44 UTC) #30
commit-bot: I haz the power
Committed patchset #2 (id:40002)
4 years, 4 months ago (2016-08-12 19:58:36 UTC) #32
commit-bot: I haz the power
4 years, 4 months ago (2016-08-12 20:00:50 UTC) #34
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aa7a8e79bcfc1680fabf697c9f473e8e7908ccaa
Cr-Commit-Position: refs/heads/master@{#411744}

Powered by Google App Engine
This is Rietveld 408576698