Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2242613003: Hoist SetNeedsBeginFrame messages up to the RWHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove base class call Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 39f5cbc36e54d8cfa728bfb39381e35bbb3e7907..8c79a121a6d72808e8ed7517f6abd4caee1136b7 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -428,7 +428,6 @@ RenderWidgetHostViewAura::RenderWidgetHostViewAura(RenderWidgetHost* host,
has_composition_text_(false),
accept_return_character_(false),
begin_frame_source_(nullptr),
- needs_begin_frames_(false),
synthetic_move_sent_(false),
cursor_visibility_state_in_renderer_(UNKNOWN),
#if defined(OS_WIN)
@@ -478,17 +477,6 @@ RenderWidgetHostViewAura::RenderWidgetHostViewAura(RenderWidgetHost* host,
////////////////////////////////////////////////////////////////////////////////
// RenderWidgetHostViewAura, RenderWidgetHostView implementation:
-bool RenderWidgetHostViewAura::OnMessageReceived(
- const IPC::Message& message) {
- bool handled = true;
- IPC_BEGIN_MESSAGE_MAP(RenderWidgetHostViewAura, message)
- IPC_MESSAGE_HANDLER(ViewHostMsg_SetNeedsBeginFrames,
- OnSetNeedsBeginFrames)
- IPC_MESSAGE_UNHANDLED(handled = false)
- IPC_END_MESSAGE_MAP()
- return handled;
-}
-
void RenderWidgetHostViewAura::InitAsChild(
gfx::NativeView parent_view) {
CreateAuraWindow();
@@ -711,17 +699,14 @@ ui::TextInputClient* RenderWidgetHostViewAura::GetTextInputClient() {
return this;
}
-void RenderWidgetHostViewAura::OnSetNeedsBeginFrames(bool needs_begin_frames) {
- if (needs_begin_frames_ == needs_begin_frames)
+void RenderWidgetHostViewAura::SetNeedsBeginFrames(bool needs_begin_frames) {
+ if (!begin_frame_source_)
return;
- needs_begin_frames_ = needs_begin_frames;
- if (begin_frame_source_) {
- if (needs_begin_frames_)
- begin_frame_source_->AddObserver(this);
- else
- begin_frame_source_->RemoveObserver(this);
- }
+ if (needs_begin_frames)
+ begin_frame_source_->AddObserver(this);
+ else
+ begin_frame_source_->RemoveObserver(this);
}
void RenderWidgetHostViewAura::OnBeginFrame(
@@ -2923,10 +2908,11 @@ void RenderWidgetHostViewAura::DelegatedFrameHostUpdateVSyncParameters(
void RenderWidgetHostViewAura::SetBeginFrameSource(
cc::BeginFrameSource* source) {
- if (begin_frame_source_ && needs_begin_frames_)
+ bool needs_begin_frames = host_->needs_begin_frames();
+ if (begin_frame_source_ && needs_begin_frames)
begin_frame_source_->RemoveObserver(this);
begin_frame_source_ = source;
- if (begin_frame_source_ && needs_begin_frames_)
+ if (begin_frame_source_ && needs_begin_frames)
begin_frame_source_->AddObserver(this);
}

Powered by Google App Engine
This is Rietveld 408576698