Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1923)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2242613003: Hoist SetNeedsBeginFrame messages up to the RWHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove base class call Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index dbebe33627acac2865fe07952a18198660e2da9d..d70d8711098c7f7da71bc8ae04e3b1bd345fcba6 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -380,8 +380,6 @@ bool RenderWidgetHostViewAndroid::OnMessageReceived(
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(RenderWidgetHostViewAndroid, message)
IPC_MESSAGE_HANDLER(ViewHostMsg_StartContentIntent, OnStartContentIntent)
- IPC_MESSAGE_HANDLER(ViewHostMsg_SetNeedsBeginFrames,
- OnSetNeedsBeginFrames)
IPC_MESSAGE_HANDLER(ViewHostMsg_SmartClipDataExtracted,
OnSmartClipDataExtracted)
IPC_MESSAGE_HANDLER(ViewHostMsg_ShowUnhandledTapUIIfNeeded,
@@ -665,10 +663,10 @@ void RenderWidgetHostViewAndroid::UpdateBackgroundColor(SkColor color) {
content_view_core_->OnBackgroundColorChanged(color);
}
-void RenderWidgetHostViewAndroid::OnSetNeedsBeginFrames(bool enabled) {
- TRACE_EVENT1("cc", "RenderWidgetHostViewAndroid::OnSetNeedsBeginFrames",
- "enabled", enabled);
- if (enabled)
+void RenderWidgetHostViewAndroid::SetNeedsBeginFrames(bool needs_begin_frames) {
+ TRACE_EVENT1("cc", "RenderWidgetHostViewAndroid::SetNeedsBeginFrames",
+ "needs_begin_frames", needs_begin_frames);
+ if (needs_begin_frames)
RequestVSyncUpdate(PERSISTENT_BEGIN_FRAME);
else
outstanding_vsync_requests_ &= ~PERSISTENT_BEGIN_FRAME;

Powered by Google App Engine
This is Rietveld 408576698