Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: content/browser/frame_host/render_widget_host_view_child_frame.h

Issue 2242613003: Hoist SetNeedsBeginFrame messages up to the RWHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove base class call Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_child_frame.h
diff --git a/content/browser/frame_host/render_widget_host_view_child_frame.h b/content/browser/frame_host/render_widget_host_view_child_frame.h
index 6d519155c0098061c958b0713f081e7ba466238a..30a84cdb940aea5f6ef51b3b9c22678787bdb297 100644
--- a/content/browser/frame_host/render_widget_host_view_child_frame.h
+++ b/content/browser/frame_host/render_widget_host_view_child_frame.h
@@ -69,7 +69,6 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame
void RegisterFrameSwappedCallback(std::unique_ptr<base::Closure> callback);
// RenderWidgetHostView implementation.
- bool OnMessageReceived(const IPC::Message& msg) override;
void InitAsChild(gfx::NativeView parent_view) override;
RenderWidgetHost* GetRenderWidgetHost() const override;
void SetSize(const gfx::Size& size) override;
@@ -88,6 +87,7 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame
void SetBackgroundColor(SkColor color) override;
gfx::Size GetPhysicalBackingSize() const override;
bool IsMouseLocked() override;
+ void SetNeedsBeginFrames(bool needs_begin_frames) override;
// RenderWidgetHostViewBase implementation.
void InitAsPopup(RenderWidgetHostView* parent_host_view,
@@ -169,8 +169,6 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame
const cc::BeginFrameArgs& LastUsedBeginFrameArgs() const override;
void OnBeginFrameSourcePausedChanged(bool paused) override;
- void OnSetNeedsBeginFrames(bool needs_begin_frames);
-
// Declared 'public' instead of 'protected' here to allow derived classes
// to Bind() to it.
void SurfaceDrawn(uint32_t output_surface_id);
@@ -241,7 +239,6 @@ class CONTENT_EXPORT RenderWidgetHostViewChildFrame
// The begin frame source being observed. Null if none.
cc::BeginFrameSource* begin_frame_source_;
cc::BeginFrameArgs last_begin_frame_args_;
- bool observing_begin_frame_source_;
// The surface client ID of the parent RenderWidgetHostView. 0 if none.
uint32_t parent_surface_client_id_;

Powered by Google App Engine
This is Rietveld 408576698