content/browser/renderer_host/render_widget_host_view_android.cc - Issue 2242613003: Hoist SetNeedsBeginFrame messages up to the RWHostImpl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2242613003: Hoist SetNeedsBeginFrame messages up to the RWHostImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix redundant set needs begin frames Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_widget_host_view_guest.cc ('K') | « content/browser/renderer_host/render_widget_host_view_android.h ('k') | content/browser/renderer_host/render_widget_host_view_aura.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.cc

diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc

index 0f9ae4ad03bd48c1523a0dc6d50863fa6ccd0b60..4e7bd694ac69af1c9b8f2fa6d16ba6c8650c1c6b 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.cc

+++ b/content/browser/renderer_host/render_widget_host_view_android.cc

@@ -381,8 +381,6 @@ bool RenderWidgetHostViewAndroid::OnMessageReceived(

bool handled = true;

IPC_BEGIN_MESSAGE_MAP(RenderWidgetHostViewAndroid, message)

IPC_MESSAGE_HANDLER(ViewHostMsg_StartContentIntent, OnStartContentIntent)

- IPC_MESSAGE_HANDLER(ViewHostMsg_SetNeedsBeginFrames,

- OnSetNeedsBeginFrames)

IPC_MESSAGE_HANDLER(ViewHostMsg_SmartClipDataExtracted,

OnSmartClipDataExtracted)

IPC_MESSAGE_HANDLER(ViewHostMsg_ShowUnhandledTapUIIfNeeded,

@@ -666,10 +664,10 @@ void RenderWidgetHostViewAndroid::UpdateBackgroundColor(SkColor color) {

content_view_core_->OnBackgroundColorChanged(color);

}

-void RenderWidgetHostViewAndroid::OnSetNeedsBeginFrames(bool enabled) {

- TRACE_EVENT1("cc", "RenderWidgetHostViewAndroid::OnSetNeedsBeginFrames",

- "enabled", enabled);

- if (enabled)

+void RenderWidgetHostViewAndroid::SetNeedsBeginFrames(bool needs_begin_frames) {

+ TRACE_EVENT1("cc", "RenderWidgetHostViewAndroid::SetNeedsBeginFrames",

+ "needs_begin_frames", needs_begin_frames);

+ if (needs_begin_frames)

RequestVSyncUpdate(PERSISTENT_BEGIN_FRAME);

else

outstanding_vsync_requests_ &= ~PERSISTENT_BEGIN_FRAME;