Hoist SetNeedsBeginFrame messages up to the RWHostImpl

content/browser/frame_host/render_widget_host_view_guest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_widget_host_view_guest.h"
 
 #include <utility>
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
@@ skipping 232 matching lines @@
 }
 
 gfx::Size RenderWidgetHostViewGuest::GetPhysicalBackingSize() const {
   return RenderWidgetHostViewBase::GetPhysicalBackingSize();
 }
 
 base::string16 RenderWidgetHostViewGuest::GetSelectedText() {
   return platform_view_->GetSelectedText();
 }
 
+void RenderWidgetHostViewGuest::SetNeedsBeginFrames(
+    bool needs_begin_frames) {
+ RenderWidgetHostViewChildFrame::SetNeedsBeginFrames(needs_begin_frames);

[no sievers, 2016/08/15 17:39:13]

Is this an intentional change in behavior that now both the |platform_view_| and
the base class end up requesting BeginFrames?

[enne (OOO), 2016/08/15 20:49:36]

That's fair.  Previously this would only go to the platform view.  This doesn't
seem necessary.  Removed.

+ if (platform_view_)
+   platform_view_->SetNeedsBeginFrames(needs_begin_frames);
+}
+
 void RenderWidgetHostViewGuest::SetTooltipText(
     const base::string16& tooltip_text) {
   if (guest_)
     guest_->SetTooltipText(tooltip_text);
 }
 
 void RenderWidgetHostViewGuest::OnSwapCompositorFrame(
     uint32_t output_surface_id,
     cc::CompositorFrame frame) {
   TRACE_EVENT0("content", "RenderWidgetHostViewGuest::OnSwapCompositorFrame");
@@ skipping 52 matching lines @@
 
   ProcessFrameSwappedCallbacks();
 
   // If after detaching we are sent a frame, we should finish processing it, and
   // then we should clear the surface so that we are not holding resources we
   // no longer need.
   if (!guest_ || !guest_->attached())
     ClearCompositorSurfaceIfNecessary();
 }
 
 bool RenderWidgetHostViewGuest::OnMessageReceived(const IPC::Message& msg) {

[no sievers, 2016/08/15 17:39:13]

Is this unused now?
And can it also be removed from RenderWidgetHostViewBase::OnMessageReceived()
incl. the call site from RWHImpl (view_->OnMessageReceived(msg))?

[enne (OOO), 2016/08/15 20:49:36]

Can platform_view be a RenderWidgetHostViewMac? if so, then it's not unused. 
RenderWidgetHostViewMac and RenderWidgetHostViewAndroid both have other
messages, so it can't be removed from RenderWidgetHostViewBase or
RenderWidgetHostImpl.

   if (!platform_view_) {
     // In theory, we can get here if there's a delay between Destroy()
     // being called and when our destructor is invoked.
     return false;
   }
 
   return platform_view_->OnMessageReceived(msg);
 }
 
 void RenderWidgetHostViewGuest::InitAsChild(
@@ skipping 323 matching lines @@
         gesture_event.data.scrollUpdate.inertialPhase ==
             blink::WebGestureEvent::MomentumPhase) {
       return;
     }
     host_->ForwardGestureEvent(gesture_event);
     return;
   }
 }
 
 }  // namespace content