Fix bug in cubic derivative coefficient with missing parens

Fix bug in cubic derivative coefficient with missing parens

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2242603002

Committed: https://skia.googlesource.com/skia/+/db085ab30f58928623447676c46d6bd7a8cc2255

[Harry Stern, 2016-08-11 21:52:51]

Description was changed from

==========
Fix bug in cubic derivative coefficient with missing parens

BUG=skia:
==========

to

==========
Fix bug in cubic derivative coefficient with missing parens

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2242603002
==========

[Harry Stern, 2016-08-15 20:28:07]

hstern@google.com changed reviewers:
+ caryclark@google.com, reed@google.com

[Harry Stern, 2016-08-15 20:28:07]

I forgot to send this out last week

[Harry Stern, 2016-08-16 20:31:15]

On 2016/08/15 20:28:07, Harry Stern wrote:
> I forgot to send this out last week

ping/ptal

[reed1, 2016-08-16 21:19:35]

lgtm

https://codereview.chromium.org/2242603002/diff/1/src/utils/SkCurveMeasure.cpp
File src/utils/SkCurveMeasure.cpp (right):

https://codereview.chromium.org/2242603002/diff/1/src/utils/SkCurveMeasure.cp...
src/utils/SkCurveMeasure.cpp:133: yCoeff[1] = Sk8f(3.0f*(2.0f*(Ay - 2.0f*By +
Cy)));
this seems fine. two nits:

1. don't need 3.0f when 3 will do (I find the latter easier to parse)
2. for efficiency, seems better to resolve some of those constant*
expressions...
    6*(Ay - 2*By + Cy)

[Harry Stern, 2016-08-16 21:36:45]

On 2016/08/16 21:19:35, reed1 wrote:
> lgtm
> 
> https://codereview.chromium.org/2242603002/diff/1/src/utils/SkCurveMeasure.cpp
> File src/utils/SkCurveMeasure.cpp (right):
> 
>
https://codereview.chromium.org/2242603002/diff/1/src/utils/SkCurveMeasure.cp...
> src/utils/SkCurveMeasure.cpp:133: yCoeff[1] = Sk8f(3.0f*(2.0f*(Ay - 2.0f*By +
> Cy)));
> this seems fine. two nits:
> 
> 1. don't need 3.0f when 3 will do (I find the latter easier to parse)
> 2. for efficiency, seems better to resolve some of those constant*
> expressions...
>     6*(Ay - 2*By + Cy)

1. Done
2. Done, I guess I thought initially that the parens were necessary so I
couldn't factor, but I just double-checked and the current formulae is correct.

[Harry Stern, 2016-08-16 21:38:42]

The CQ bit was checked by hstern@google.com

[Harry Stern, 2016-08-16 21:38:42]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/2242603002/#ps20001
(title: "Remove extra .0f. Also 2*3 = 6")

[commit-bot: I haz the power, 2016-08-16 21:38:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 22:10:36]

Description was changed from

==========
Fix bug in cubic derivative coefficient with missing parens

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2242603002
==========

to

==========
Fix bug in cubic derivative coefficient with missing parens

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2242603002

Committed:
https://skia.googlesource.com/skia/+/db085ab30f58928623447676c46d6bd7a8cc2255
==========

[commit-bot: I haz the power, 2016-08-16 22:10:38]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/db085ab30f58928623447676c46d6bd7a8cc2255