Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 22426003: Handlify factory methods for typed array, ArrayBuffer and DataView. (Closed)

Created:
7 years, 4 months ago by Dmitry Lomov (no reviews)
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Handlify factory methods for typed array, ArrayBuffer and DataView. These factory methods used pointers for constructor fucntions, therefore those pointers could corrupt if allocation triggered gc. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16084

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -29 lines) Patch
M src/factory.cc View 1 chunk +26 lines, -29 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Dmitry Lomov (no reviews)
Daniel/Michael, please take a look. This is a cause of WebAudio test failures after I ...
7 years, 4 months ago (2013-08-06 17:05:42 UTC) #1
Michael Starzinger
LGTM (with a nit). https://codereview.chromium.org/22426003/diff/1/src/factory.cc File src/factory.cc (right): https://codereview.chromium.org/22426003/diff/1/src/factory.cc#newcode1159 src/factory.cc:1159: GetTypedArrayFun(type, native_context)); nit: Instead of ...
7 years, 4 months ago (2013-08-06 18:05:45 UTC) #2
Dmitry Lomov (no reviews)
Committed patchset #1 manually as r16084 (presubmit successful).
7 years, 4 months ago (2013-08-06 19:14:56 UTC) #3
Dmitry Lomov (no reviews)
7 years, 4 months ago (2013-08-06 19:15:09 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/22426003/diff/1/src/factory.cc
File src/factory.cc (right):

https://codereview.chromium.org/22426003/diff/1/src/factory.cc#newcode1159
src/factory.cc:1159: GetTypedArrayFun(type, native_context));
On 2013/08/06 18:05:46, Michael Starzinger wrote:
> nit: Instead of passing "Context*" into GetTypedArrayFun() can we instead pass
> in "Isolate*"? Just to prevent accidental use of the potentially stale
> "native_context" variable here.

Done, great idea - thanks!

Powered by Google App Engine
This is Rietveld 408576698