appengine/swarming/elements/res/imp/common/swarming-app.html - Issue 2242543002: Make OAuth client id accessible to new ui w/o hardcoding

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/swarming/elements/res/imp/common/swarming-app.html

Issue 2242543002: Make OAuth client id accessible to new ui w/o hardcoding (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master

Patch Set: Address nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/swarming/elements/res/imp/botlist/bot-list.html ('k') | appengine/swarming/elements/res/imp/index/swarming-index.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/swarming/elements/res/imp/common/swarming-app.html

diff --git a/appengine/swarming/elements/res/imp/common/swarming-app.html b/appengine/swarming/elements/res/imp/common/swarming-app.html

index 071fb9dc821654e4fbbe11429a54b386aa76bfce..27031dcb305d13a65aeda1ed2d19205ba603313e 100644

--- a/appengine/swarming/elements/res/imp/common/swarming-app.html

+++ b/appengine/swarming/elements/res/imp/common/swarming-app.html

@@ -82,10 +82,9 @@

-

<auth-signin

class="right"

- client-id="20770472288-t5smpbpjptka4nd888fv0ctd23ftba2o.apps.googleusercontent.com"

+ client-id="[[client_id]]"

auth-headers="{{auth_headers}}"

signed-in="{{signed_in}}">

</auth-signin>

@@ -101,6 +100,9 @@

Polymer({

is: 'swarming-app',

properties: {

+ client_id: {

+ type: String,

+ },

auth_headers: {

type: Object,

notify: true,