Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 224253003: Revert of Xfermode: SSE2 implementation of multiply_modeproc (Closed)

Created:
6 years, 8 months ago by robertphillips
Modified:
6 years, 8 months ago
Reviewers:
mtklein, qiankun
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@xfermode
Visibility:
Public.

Description

Revert of Xfermode: SSE2 implementation of multiply_modeproc (https://codereview.chromium.org/202903004/) Reason for revert: It looks like serialization is broken. The serialize and pipe-cross-process tests are failing and turning (at least the Ubuntu12 and Win7) bots red Original issue's description: > Xfermode: SSE2 implementation of multiply_modeproc > > This patch implements basics for Xfermode SSE optimization. Based on > these basics, SSE2 implementation of multiply_modeproc is provided. SSE2 > implementation for other modes will come in future. With this patch > performance of Xfermode_Multiply will improve about 45%. Here are the > data on desktop i7-3770. > before: > Xfermode_Multiply 8888: cmsecs = 33.30 565: cmsecs = 45.65 > after: > Xfermode_Multiply 8888: cmsecs = 17.18 565: cmsecs = 24.87 > > BUG= > > Committed: http://code.google.com/p/skia/source/detail?r=14006 > > Committed: http://code.google.com/p/skia/source/detail?r=14050 TBR=mtklein@google.com,qiankun.miao@intel.com NOTREECHECKS=true NOTRY=true BUG= Committed: http://code.google.com/p/skia/source/detail?r=14053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -479 lines) Patch
M gyp/opts.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkXfermode.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M src/opts/SkBlitRow_opts_SSE2.cpp View 5 chunks +20 lines, -20 lines 0 comments Download
M src/opts/SkColor_opts_SSE2.h View 2 chunks +8 lines, -123 lines 0 comments Download
D src/opts/SkXfermode_opts_SSE2.h View 1 chunk +0 lines, -32 lines 0 comments Download
D src/opts/SkXfermode_opts_SSE2.cpp View 1 chunk +0 lines, -265 lines 0 comments Download
M src/opts/opts_check_SSE2.cpp View 2 chunks +0 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertphillips
Created Revert of Xfermode: SSE2 implementation of multiply_modeproc
6 years, 8 months ago (2014-04-03 18:53:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/224253003/1
6 years, 8 months ago (2014-04-03 18:53:26 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 18:53:50 UTC) #3
Message was sent while issue was closed.
Change committed as 14053

Powered by Google App Engine
This is Rietveld 408576698