Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1088)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 22425006: Fix equality of implicit closures in the Dart VM. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/bootstrap_natives.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.cc
===================================================================
--- runtime/vm/class_finalizer.cc (revision 26064)
+++ runtime/vm/class_finalizer.cc (working copy)
@@ -1540,9 +1540,6 @@
name.ToCString());
}
cls.set_is_type_finalized();
- // Signature classes extend Object. No need to add this class to the direct
- // subclasses of Object.
- ASSERT(super_type.IsNull() || super_type.IsObjectType());
// The type parameters of signature classes may have bounds.
FinalizeUpperBounds(cls);
@@ -1934,8 +1931,7 @@
// Special case: classes for which we don't have a known class id.
if (super_type.IsDoubleType() ||
super_type.IsIntType() ||
- super_type.IsStringType() ||
- super_type.IsFunctionType()) {
+ super_type.IsStringType()) {
is_error = true;
}
break;
@@ -1985,7 +1981,6 @@
interface.IsIntType() ||
interface.IsDoubleType() ||
interface.IsStringType() ||
- (interface.IsFunctionType() && !cls.IsSignatureClass()) ||
interface.IsDynamicType()) {
const Script& script = Script::Handle(cls.script());
ReportError(Error::Handle(), // No previous error.
« no previous file with comments | « runtime/vm/bootstrap_natives.h ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698