Send RenderViewReady when a RVH is reused and becomes active.

content/browser/frame_host/render_frame_host_manager_browsertest.cc

Index: content/browser/frame_host/render_frame_host_manager_browsertest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_browsertest.cc b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
index f642981a5f4ff0f633ad6c9feb0398848618f31e..acba5bafffb491d60f31ca4f0d74031585de9df3 100644
--- a/content/browser/frame_host/render_frame_host_manager_browsertest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
@@ -2768,7 +2768,7 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest, CtrlClickSubframeLink) {
 
 // Ensure that we don't update the wrong NavigationEntry's title after an
 // ignored commit during a cross-process navigation.
-// See https://crbug.con/577449.
+// See https://crbug.com/577449.
 IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
                        UnloadPushStateOnCrossProcessNavigation) {
   StartEmbeddedServer();
@@ -2835,4 +2835,46 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
   EXPECT_TRUE(web_contents->GetMainFrame()->IsRenderFrameLive());
 }
 
+// Ensure that navigating back from a sad tab to an existing process works
+// correctly. See https://crbug.com/591984.
+IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
+                       NavigateBackToExistingProcessFromSadTab) {
+  StartEmbeddedServer();
+  EXPECT_TRUE(NavigateToURL(
+      shell(), embedded_test_server()->GetURL("a.com", "/title1.html")));
+
+  // Open a popup and navigate it to b.com.
+  Shell* popup = OpenPopup(
+      shell(), embedded_test_server()->GetURL("a.com", "/title2.html"), "foo");
+  EXPECT_TRUE(NavigateToURL(
+      popup, embedded_test_server()->GetURL("b.com", "/title3.html")));
+
+  // Kill the b.com process.
+  RenderProcessHost* b_process =
+      popup->web_contents()->GetMainFrame()->GetProcess();
+  RenderProcessHostWatcher crash_observer(
+      b_process, RenderProcessHostWatcher::WATCH_FOR_PROCESS_EXIT);
+  b_process->Shutdown(0, false);
+  crash_observer.Wait();
+
+  // The popup should now be showing the sad tab.  Main tab should not be.
+  EXPECT_EQ(popup->web_contents()->GetCrashedStatus(),
+            base::TERMINATION_STATUS_PROCESS_WAS_KILLED);

[Charlie Reis, 2016/08/11 18:55:52]

nit: Reverse order (expected, actual)

Also, this seems to be failing on Windows.  (Or maybe the one below?)

[alexmos, 2016/08/11 21:34:30]

Done.  Apparently on Windows, GetCrashedStatus() returns
TERMINATION_STATUS_NORMAL_TERMINATION instead of 
TERMINATION_STATUS_PROCESS_WAS_KILLED here.  I fixed it by comparing that the
status is not RUNNING.

+  EXPECT_EQ(shell()->web_contents()->GetCrashedStatus(),
+            base::TERMINATION_STATUS_STILL_RUNNING);
+
+  // Go back in the popup from b.com to a.com/title2.html.
+  TestNavigationObserver back_observer(popup->web_contents());
+  popup->web_contents()->GetController().GoBack();
+  back_observer.Wait();
+
+  // In the bug, after the back navigation the popup was still showing
+  // the sad tab.  Ensure this is not the case.
+  EXPECT_EQ(popup->web_contents()->GetCrashedStatus(),
+            base::TERMINATION_STATUS_STILL_RUNNING);
+  EXPECT_TRUE(popup->web_contents()->GetMainFrame()->IsRenderFrameLive());
+  EXPECT_EQ(popup->web_contents()->GetMainFrame()->GetSiteInstance(),
+            shell()->web_contents()->GetMainFrame()->GetSiteInstance());
+}
+
 }  // namespace content