Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 2242493002: Send RenderViewReady when a RVH is reused and becomes active. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Charlie's nit and Windows test fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_browsertest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 const ViewHostMsg_CreateWindow_Params& params, 234 const ViewHostMsg_CreateWindow_Params& params,
235 SessionStorageNamespace* session_storage_namespace); 235 SessionStorageNamespace* session_storage_namespace);
236 236
237 // Creates a new RenderWidget with the given route id. |popup_type| indicates 237 // Creates a new RenderWidget with the given route id. |popup_type| indicates
238 // if this widget is a popup and what kind of popup it is (select, autofill). 238 // if this widget is a popup and what kind of popup it is (select, autofill).
239 void CreateNewWidget(int32_t route_id, blink::WebPopupType popup_type); 239 void CreateNewWidget(int32_t route_id, blink::WebPopupType popup_type);
240 240
241 // Creates a full screen RenderWidget. 241 // Creates a full screen RenderWidget.
242 void CreateNewFullscreenWidget(int32_t route_id); 242 void CreateNewFullscreenWidget(int32_t route_id);
243 243
244 // Send RenderViewReady to observers once the process is launched, but not
245 // re-entrantly.
246 void PostRenderViewReady();
247
244 // TODO(creis): Remove after debugging https:/crbug.com/575245. 248 // TODO(creis): Remove after debugging https:/crbug.com/575245.
245 int main_frame_routing_id() const { 249 int main_frame_routing_id() const {
246 return main_frame_routing_id_; 250 return main_frame_routing_id_;
247 } 251 }
248 252
249 void set_main_frame_routing_id(int routing_id) { 253 void set_main_frame_routing_id(int routing_id) {
250 main_frame_routing_id_ = routing_id; 254 main_frame_routing_id_ = routing_id;
251 } 255 }
252 256
253 // Increases the refcounting on this RVH. This is done by the FrameTree on 257 // Increases the refcounting on this RVH. This is done by the FrameTree on
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
314 // specific code away from this class. 318 // specific code away from this class.
315 friend class RenderFrameHostImpl; 319 friend class RenderFrameHostImpl;
316 friend class TestRenderViewHost; 320 friend class TestRenderViewHost;
317 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, BasicRenderFrameHost); 321 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, BasicRenderFrameHost);
318 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, RoutingIdSane); 322 FRIEND_TEST_ALL_PREFIXES(RenderViewHostTest, RoutingIdSane);
319 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostManagerTest, 323 FRIEND_TEST_ALL_PREFIXES(RenderFrameHostManagerTest,
320 CleanUpSwappedOutRVHOnProcessCrash); 324 CleanUpSwappedOutRVHOnProcessCrash);
321 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest, 325 FRIEND_TEST_ALL_PREFIXES(SitePerProcessBrowserTest,
322 NavigateMainFrameToChildSite); 326 NavigateMainFrameToChildSite);
323 327
324 // Send RenderViewReady to observers once the process is launched, but not
325 // re-entrantly.
326 void PostRenderViewReady();
327 void RenderViewReady(); 328 void RenderViewReady();
328 329
329 // TODO(creis): Move to a private namespace on RenderFrameHostImpl. 330 // TODO(creis): Move to a private namespace on RenderFrameHostImpl.
330 // Delay to wait on closing the WebContents for a beforeunload/unload handler 331 // Delay to wait on closing the WebContents for a beforeunload/unload handler
331 // to fire. 332 // to fire.
332 static const int64_t kUnloadTimeoutMS; 333 static const int64_t kUnloadTimeoutMS;
333 334
334 // Returns the content specific prefs for this RenderViewHost. 335 // Returns the content specific prefs for this RenderViewHost.
335 // TODO(creis): Move most of this method to RenderProcessHost, since it's 336 // TODO(creis): Move most of this method to RenderProcessHost, since it's
336 // mostly the same across all RVHs in a process. Move the rest to RFH. 337 // mostly the same across all RVHs in a process. Move the rest to RFH.
(...skipping 67 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 bool render_view_ready_on_process_launch_; 405 bool render_view_ready_on_process_launch_;
405 406
406 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_; 407 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;
407 408
408 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl); 409 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
409 }; 410 };
410 411
411 } // namespace content 412 } // namespace content
412 413
413 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 414 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698