Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2242483003: Add asio's coroutine.hpp for C++ coroutine support (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add asio's coroutine.hpp for C++ coroutine support R=ikilpatrick@chromium.org,eae@chromium.org BUG=635619

Patch Set 1 #

Patch Set 2 : android compatible is yes, per xam@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -0 lines) Patch
A third_party/asio/LICENSE_1_0.txt View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/asio/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/asio/README.chromium View 1 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/asio/src/asio/coroutine.hpp View 1 chunk +328 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ryan Sleevi
Drive-by: This doesn't seem allowed by https://google.github.io/styleguide/cppguide.html#Boost
4 years, 4 months ago (2016-08-11 18:02:10 UTC) #2
cbiesinger
On 2016/08/11 18:02:10, Ryan Sleevi (slow) wrote: > Drive-by: This doesn't seem allowed by > ...
4 years, 4 months ago (2016-08-11 18:07:33 UTC) #3
Ryan Sleevi
They're basically the same thing, except the non-boost version includes some of its own support ...
4 years, 4 months ago (2016-08-11 19:52:15 UTC) #4
ikilpatrick
+jyasskin Right we discussed this with jyasskin about about this last week; and this seemed ...
4 years, 4 months ago (2016-08-11 20:17:44 UTC) #7
xam
On 2016/08/11 20:17:44, ikilpatrick wrote: > +jyasskin > > Right we discussed this with jyasskin ...
4 years, 4 months ago (2016-08-11 20:22:38 UTC) #8
Jeffrey Yasskin
4 years, 4 months ago (2016-08-11 21:10:36 UTC) #9
On 2016/08/11 20:17:44, ikilpatrick wrote:
> +jyasskin
> 
> Right we discussed this with jyasskin about about this last week; and this
> seemed to the best library to fit our needs short of rolling our own.
> 
> In an ideal world we'd wait until c++XX has resumable functions but we don't
> live in that world quite yet :)
> 
> jyasskin thoughts?

It's reasonable to check with our local style folks. I don't think it makes
sense to ask the Google arbiters to allow this library, since there's no google
code that wants to use it.

One reason Boost libraries are banned is that they tend to pull in the world,
but this one's standalone, so that argument against doesn't apply. The bigger
risk with this library is that we'll find something subtly confusing about the
'yield' style it encourages. That's a bit mitigated if it's compatible with the
C++ proposal that's already implemented in MSVC.

Powered by Google App Engine
This is Rietveld 408576698