Fix fast/repaint/obscured-background-no-repaint.html

Fix fast/repaint/obscured-background-no-repaint.html

When the test ran on release bots, the foreground image was never
decoded so its opaqueness was always assumed false, and the animated
background was always assumed not obscured.

(The original test passed with debug build and CQ bots perhaps because
of different timing/scheduling.)

Force rasterization (in which deferred image decoding is done) with
testRunner.capturePixelAsyncThen().

BUG=636992
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7c55a94f60a068dc771419c771483bbf6f94c552
Cr-Commit-Position: refs/heads/master@{#411402}

[Xianzhu, 2016-08-11 17:24:33]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[Xianzhu, 2016-08-11 17:24:55]

wangxianzhu@chromium.org changed reviewers:
+ chrishtr@chromium.org

[commit-bot: I haz the power, 2016-08-11 17:25:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-08-11 17:33:44]

https://codereview.chromium.org/2242483002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html
(right):

https://codereview.chromium.org/2242483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html:67:
if (invalidations) {
Why would |invalidations| sometimes be false in a test?

https://codereview.chromium.org/2242483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html:91:
setTimeout(finish, 300);
Use internals.advanceTimeForImage for this.

[Xianzhu, 2016-08-11 18:10:07]

https://codereview.chromium.org/2242483002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html
(right):

https://codereview.chromium.org/2242483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html:67:
if (invalidations) {
On 2016/08/11 17:33:44, chrishtr wrote:
> Why would |invalidations| sometimes be false in a test?

It will be undefined if there is no invalidations. This is expected, as well as
invalidations including 'background obscuration change' for 'target3' and/or
'target4' only, depending on timing.

https://codereview.chromium.org/2242483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html:91:
setTimeout(finish, 300);
On 2016/08/11 17:33:44, chrishtr wrote:
> Use internals.advanceTimeForImage for this.

Tried it in the latest patch set, and modified code to enable the bug, but
couldn't reproduce the bug with the modified test. Is the usage in the latest
patch correct?

[Xianzhu, 2016-08-11 18:10:44]

Description was changed from

==========
Fix fast/repaint/obscured-background-no-repaint.html

When the test ran on release bots, the foreground image was never
decoded so its opaqueness was always assumed false, and the animated
background was always assumed not obscured.

(The original test passed with debug build and CQ bots perhaps because
of different timing/scheduling.)

Force rasterization (in which deferred image decoding is done) with
testRunner.capturePixelAsyncThen().

BUG=636992
==========

to

==========
Fix fast/repaint/obscured-background-no-repaint.html

When the test ran on release bots, the foreground image was never
decoded so its opaqueness was always assumed false, and the animated
background was always assumed not obscured.

(The original test passed with debug build and CQ bots perhaps because
of different timing/scheduling.)

Force rasterization (in which deferred image decoding is done) with
testRunner.capturePixelAsyncThen().

BUG=636992
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-08-11 18:16:26]

https://codereview.chromium.org/2242483002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html
(right):

https://codereview.chromium.org/2242483002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/repaint/obscured-background-no-repaint.html:91:
setTimeout(finish, 300);
On 2016/08/11 18:10:07, Xianzhu wrote:
> On 2016/08/11 17:33:44, chrishtr wrote:
> > Use internals.advanceTimeForImage for this.
> 
> Tried it in the latest patch set, and modified code to enable the bug, but
> couldn't reproduce the bug with the modified test. Is the usage in the latest
> patch correct?

Never mind. I can reproduce the bug with internal.advanceImageAnimation().

[chrishtr, 2016-08-11 18:20:14]

lgtm

[Xianzhu, 2016-08-11 18:22:55]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-08-11 18:22:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/2242483002/#ps40001
(title: "-")

[commit-bot: I haz the power, 2016-08-11 18:23:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 19:39:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-11 19:40:51]

Description was changed from

==========
Fix fast/repaint/obscured-background-no-repaint.html

When the test ran on release bots, the foreground image was never
decoded so its opaqueness was always assumed false, and the animated
background was always assumed not obscured.

(The original test passed with debug build and CQ bots perhaps because
of different timing/scheduling.)

Force rasterization (in which deferred image decoding is done) with
testRunner.capturePixelAsyncThen().

BUG=636992
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Fix fast/repaint/obscured-background-no-repaint.html

When the test ran on release bots, the foreground image was never
decoded so its opaqueness was always assumed false, and the animated
background was always assumed not obscured.

(The original test passed with debug build and CQ bots perhaps because
of different timing/scheduling.)

Force rasterization (in which deferred image decoding is done) with
testRunner.capturePixelAsyncThen().

BUG=636992
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/7c55a94f60a068dc771419c771483bbf6f94c552
Cr-Commit-Position: refs/heads/master@{#411402}
==========

[commit-bot: I haz the power, 2016-08-11 19:40:52]

Patchset 3 (id:??) landed as
https://crrev.com/7c55a94f60a068dc771419c771483bbf6f94c552
Cr-Commit-Position: refs/heads/master@{#411402}