Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1791)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java

Issue 2242473002: Add an about:flag to control WebApk enablement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nbuild ch Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java
index 1f74905ebf285ede97bbf238f5cf80ae9cd4e6ed..7136bc655808489419e81983ee58672b6240f64f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java
@@ -13,10 +13,8 @@ import android.util.Base64;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.ApplicationStatus;
-import org.chromium.base.CommandLine;
import org.chromium.base.ContextUtils;
import org.chromium.base.Log;
-import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.IntentHandler;
import org.chromium.chrome.browser.ShortcutHelper;
import org.chromium.chrome.browser.ShortcutSource;
@@ -65,9 +63,7 @@ public class WebappLauncherActivity extends Activity {
// - the request was for a WebAPK that is valid;
// - the MAC is present and valid for the homescreen shortcut to be opened;
// - the intent was sent by Chrome.
- if (CommandLine.getInstance().hasSwitch(ChromeSwitches.ENABLE_WEBAPK)) {
- ChromeWebApkHost.init();
- }
+ ChromeWebApkHost.init();
boolean isValidWebApk = isValidWebApk(webApkPackageName, webappUrl);
if (isValidWebApk
@@ -194,8 +190,7 @@ public class WebappLauncherActivity extends Activity {
* @return true iff all validation criteria are met.
*/
private boolean isValidWebApk(String webApkPackage, String url) {
- if (!CommandLine.getInstance().hasSwitch(ChromeSwitches.ENABLE_WEBAPK)
- || webApkPackage == null) {
+ if (webApkPackage == null || !ChromeWebApkHost.isEnabled()) {
return false;
}
if (!webApkPackage.equals(WebApkValidator.queryWebApkPackage(this, url))) {

Powered by Google App Engine
This is Rietveld 408576698