chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java - Issue 2242473002: Add an about:flag to control WebApk enablement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

Issue 2242473002: Add an about:flag to control WebApk enablement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nbuild ch Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/init/ChromeBrowserInitializer.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

index b080c8ec96092bb8a42bdccb3a9b1cd5517293c3..43e89d0794592978836a88eea53818520077d008 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java

@@ -37,6 +37,7 @@ import org.chromium.chrome.browser.preferences.website.SingleCategoryPreferences

import org.chromium.chrome.browser.preferences.website.SingleWebsitePreferences;

import org.chromium.chrome.browser.preferences.website.SiteSettingsCategory;

import org.chromium.chrome.browser.util.UrlUtilities;

+import org.chromium.chrome.browser.webapps.ChromeWebApkHost;

import org.chromium.chrome.browser.widget.RoundedIconGenerator;

import org.chromium.webapk.lib.client.WebApkValidator;

@@ -169,6 +170,8 @@ public class NotificationPlatformBridge {

@CalledByNative

private String queryWebApkPackage(String url) {

+ if (!ChromeWebApkHost.isEnabled()) return "";

String webApkPackage =

WebApkValidator.queryWebApkPackage(mAppContext, url);

return webApkPackage == null ? "" : webApkPackage;

@@ -204,7 +207,7 @@ public class NotificationPlatformBridge {

if (NotificationConstants.ACTION_CLICK_NOTIFICATION.equals(intent.getAction())) {

String webApkPackage = "";

- if (CommandLine.getInstance().hasSwitch(ChromeSwitches.ENABLE_WEBAPK)) {

+ if (ChromeWebApkHost.isEnabled()) {

webApkPackage = intent.getStringExtra(

NotificationConstants.EXTRA_NOTIFICATION_INFO_WEBAPK_PACKAGE);

if (webApkPackage == null) {