Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2242473002: Add an about:flag to control WebApk enablement. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix last native reference Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2034 matching lines...) Expand 10 before | Expand all | Expand 10 after
2045 ENABLE_DISABLE_VALUE_TYPE(chromeos::switches::kEnableFilesQuickView, 2045 ENABLE_DISABLE_VALUE_TYPE(chromeos::switches::kEnableFilesQuickView,
2046 chromeos::switches::kDisableFilesQuickView)}, 2046 chromeos::switches::kDisableFilesQuickView)},
2047 {"quick-unlock-pin", IDS_FLAGS_QUICK_UNLOCK_PIN, 2047 {"quick-unlock-pin", IDS_FLAGS_QUICK_UNLOCK_PIN,
2048 IDS_FLAGS_QUICK_UNLOCK_PIN_DESCRIPTION, kOsCrOS, 2048 IDS_FLAGS_QUICK_UNLOCK_PIN_DESCRIPTION, kOsCrOS,
2049 FEATURE_VALUE_TYPE(features::kQuickUnlockPin)}, 2049 FEATURE_VALUE_TYPE(features::kQuickUnlockPin)},
2050 #endif // defined(OS_CHROMEOS) 2050 #endif // defined(OS_CHROMEOS)
2051 {"browser-task-scheduler", IDS_FLAGS_BROWSER_TASK_SCHEDULER_NAME, 2051 {"browser-task-scheduler", IDS_FLAGS_BROWSER_TASK_SCHEDULER_NAME,
2052 IDS_FLAGS_BROWSER_TASK_SCHEDULER_DESCRIPTION, kOsAll, 2052 IDS_FLAGS_BROWSER_TASK_SCHEDULER_DESCRIPTION, kOsAll,
2053 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableBrowserTaskScheduler, 2053 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableBrowserTaskScheduler,
2054 switches::kDisableBrowserTaskScheduler)}, 2054 switches::kDisableBrowserTaskScheduler)},
2055 #if defined(OS_ANDROID)
2056 {"enable-webapk", IDS_FLAGS_ENABLE_WEBAPK,
2057 IDS_FLAGS_ENABLE_WEBAPK_DESCRIPTION, kOsAndroid,
2058 SINGLE_VALUE_TYPE(switches::kEnableWebApk)},
2059 #endif
2055 // NOTE: Adding new command-line switches requires adding corresponding 2060 // NOTE: Adding new command-line switches requires adding corresponding
2056 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2061 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2057 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2062 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2058 }; 2063 };
2059 2064
2060 class FlagsStateSingleton { 2065 class FlagsStateSingleton {
2061 public: 2066 public:
2062 FlagsStateSingleton() 2067 FlagsStateSingleton()
2063 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2068 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2064 ~FlagsStateSingleton() {} 2069 ~FlagsStateSingleton() {}
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
2235 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2240 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2236 2241
2237 const FeatureEntry* GetFeatureEntries(size_t* count) { 2242 const FeatureEntry* GetFeatureEntries(size_t* count) {
2238 *count = arraysize(kFeatureEntries); 2243 *count = arraysize(kFeatureEntries);
2239 return kFeatureEntries; 2244 return kFeatureEntries;
2240 } 2245 }
2241 2246
2242 } // namespace testing 2247 } // namespace testing
2243 2248
2244 } // namespace about_flags 2249 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698