Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: test/cctest/interpreter/bytecode_expectations/Conditional.golden

Issue 2242463002: [interpreter] VisitForTest for bytecode generator (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: nit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/bytecode_expectations/Conditional.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/Conditional.golden b/test/cctest/interpreter/bytecode_expectations/Conditional.golden
index e051d45cf087febd922c638cae7617566763f672..ddaf989ca3e5c997ac774776bdb7369b0777e12d 100644
--- a/test/cctest/interpreter/bytecode_expectations/Conditional.golden
+++ b/test/cctest/interpreter/bytecode_expectations/Conditional.golden
@@ -13,14 +13,10 @@ snippet: "
"
frame size: 0
parameter count: 1
-bytecode array length: 12
+bytecode array length: 4
bytecodes: [
/* 30 E> */ B(StackCheck),
- /* 34 S> */ B(LdaSmi), U8(1),
- B(JumpIfToBooleanFalse), U8(6),
- B(LdaSmi), U8(2),
- B(Jump), U8(4),
- B(LdaSmi), U8(3),
+ /* 34 S> */ B(LdaSmi), U8(2),
/* 52 S> */ B(Return),
]
constant pool: [
@@ -34,19 +30,58 @@ snippet: "
"
frame size: 0
parameter count: 1
-bytecode array length: 20
+bytecode array length: 4
bytecodes: [
/* 30 E> */ B(StackCheck),
- /* 34 S> */ B(LdaSmi), U8(1),
- B(JumpIfToBooleanFalse), U8(14),
+ /* 34 S> */ B(LdaSmi), U8(3),
+ /* 60 S> */ B(Return),
+]
+constant pool: [
+]
+handlers: [
+]
+
+---
+snippet: "
+ return 0 < 1 ? 2 : 3;
+"
+frame size: 1
+parameter count: 1
+bytecode array length: 17
+bytecodes: [
+ /* 30 E> */ B(StackCheck),
+ /* 34 S> */ B(LdaZero),
+ B(Star), R(0),
+ B(LdaSmi), U8(1),
+ /* 43 E> */ B(TestLessThan), R(0),
+ B(JumpIfFalse), U8(6),
B(LdaSmi), U8(2),
- B(JumpIfToBooleanFalse), U8(6),
- B(LdaSmi), U8(3),
B(Jump), U8(4),
- B(LdaSmi), U8(4),
+ B(LdaSmi), U8(3),
+ /* 56 S> */ B(Return),
+]
+constant pool: [
+]
+handlers: [
+]
+
+---
+snippet: "
+ var x = 0;
+ return x ? 2 : 3;
+"
+frame size: 1
+parameter count: 1
+bytecode array length: 13
+bytecodes: [
+ /* 30 E> */ B(StackCheck),
+ /* 42 S> */ B(LdaZero),
+ B(Star), R(0),
+ /* 45 S> */ B(JumpIfToBooleanFalse), U8(6),
+ B(LdaSmi), U8(2),
B(Jump), U8(4),
- B(LdaSmi), U8(5),
- /* 60 S> */ B(Return),
+ B(LdaSmi), U8(3),
+ /* 63 S> */ B(Return),
]
constant pool: [
]

Powered by Google App Engine
This is Rietveld 408576698